-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parquet-sdk]migrate objects [pt2] #641
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5d38eb5
to
70d8577
Compare
4ba014f
to
17380f2
Compare
70d8577
to
9ba9c5b
Compare
17380f2
to
09bbf57
Compare
9ba9c5b
to
d696fa3
Compare
09bbf57
to
5ac554a
Compare
d696fa3
to
5cdcf00
Compare
5ac554a
to
461e8e2
Compare
5cdcf00
to
6466470
Compare
461e8e2
to
5d72b43
Compare
6466470
to
055afb7
Compare
5d72b43
to
50c3256
Compare
055afb7
to
fb86376
Compare
50c3256
to
e17ef44
Compare
fb86376
to
dd3d690
Compare
416d2a1
to
c57057f
Compare
dd3d690
to
e715374
Compare
c57057f
to
d37f9ec
Compare
e715374
to
427bb32
Compare
d37f9ec
to
b28c1bd
Compare
@@ -126,7 +128,7 @@ impl RawObject { | |||
txn_version: i64, | |||
write_set_change_index: i64, | |||
object_mapping: &AHashMap<CurrentObjectPK, RawCurrentObject>, | |||
conn: &mut DbPoolConnection<'_>, | |||
conn: &mut Option<DbPoolConnection<'_>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke offline; we thought it doesn't make sense to have a required query_retries
and q_retry_delay
when the client isn't present. At the same time, having all as option could lead to some user error. Agreed on introducing a new struct DbConnection
as an Optional parameter with all three fields as required.
427bb32
to
a54e4d5
Compare
b28c1bd
to
4ddadba
Compare
a906016
to
bd8a1ca
Compare
4ddadba
to
e837cca
Compare
bd8a1ca
to
97eccf2
Compare
e837cca
to
20a4696
Compare
5dfd840
to
2eebae8
Compare
if db_context.is_none() { | ||
// This is a hack to prevent the program for parquet | ||
Ok(Some(( | ||
Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2eebae8
to
a0c8208
Compare
@@ -284,3 +284,9 @@ where | |||
Ok(()) | |||
} | |||
} | |||
|
|||
pub struct DbContext<'a> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Description
these fields are the ones from the prev owner
Test Plan
objects
current objects