Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parquet-sdk]migrate objects [pt1] #640

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

yuunlimm
Copy link
Contributor

No description provided.

Copy link
Contributor Author

yuunlimm commented Dec 11, 2024

@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from ab1497e to 5d38eb5 Compare December 11, 2024 18:40
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 82.70270% with 32 lines in your changes missing coverage. Please review.

Project coverage is 48.2%. Comparing base (e3ac2e9) to head (bd8a1ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/db/common/models/object_models/raw_v2_objects.rs 84.7% 21 Missing ⚠️
rust/processor/src/processors/objects_processor.rs 0.0% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #640   +/-   ##
=====================================
  Coverage   48.1%   48.2%           
=====================================
  Files        228     229    +1     
  Lines      26964   27012   +48     
=====================================
+ Hits       12986   13025   +39     
- Misses     13978   13987    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 6bfefc8 to 2cf9dfd Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 5d38eb5 to 70d8577 Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 2cf9dfd to 6349351 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 70d8577 to 9ba9c5b Compare December 11, 2024 21:08
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 6349351 to 4993938 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 9ba9c5b to d696fa3 Compare December 11, 2024 22:18
Copy link
Contributor

@dermanyang dermanyang Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file to raw_v2_objects.rs

@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 4993938 to 1b4a395 Compare December 11, 2024 23:43
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from d696fa3 to 5cdcf00 Compare December 11, 2024 23:43
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 1b4a395 to ef3609f Compare December 11, 2024 23:54
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 5cdcf00 to 6466470 Compare December 11, 2024 23:54
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from ef3609f to d448651 Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 6466470 to 055afb7 Compare December 12, 2024 02:23
@yuunlimm yuunlimm marked this pull request as ready for review December 12, 2024 03:29
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from d448651 to 846e23c Compare December 12, 2024 03:31
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 055afb7 to fb86376 Compare December 12, 2024 03:32
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 846e23c to 979c1b8 Compare December 12, 2024 03:47
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from fb86376 to dd3d690 Compare December 12, 2024 03:47
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 979c1b8 to 16f4323 Compare December 16, 2024 16:50
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from dd3d690 to e715374 Compare December 16, 2024 16:50
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 16f4323 to 84a6dff Compare December 16, 2024 17:05
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from e715374 to 427bb32 Compare December 16, 2024 17:05
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 84a6dff to a0b8ae9 Compare December 16, 2024 20:28
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from 427bb32 to a54e4d5 Compare December 16, 2024 20:28
@yuunlimm yuunlimm changed the base branch from 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ to graphite-base/640 December 16, 2024 21:32
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from a54e4d5 to a906016 Compare December 16, 2024 21:33
@yuunlimm yuunlimm changed the base branch from graphite-base/640 to main December 16, 2024 21:33
@yuunlimm yuunlimm force-pushed the 12-11-_parquet-sdk_migrate_objects_pt1_ branch from a906016 to bd8a1ca Compare December 16, 2024 21:33
@yuunlimm yuunlimm merged commit 97eccf2 into main Dec 16, 2024
11 checks passed
@yuunlimm yuunlimm deleted the 12-11-_parquet-sdk_migrate_objects_pt1_ branch December 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants