Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parquet-sdk][token_v2] migrate token ownership table [pt1] #637

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[parquet-sdk][token_v2] migrate token ownership table [pt1] #637

merged 2 commits into from
Dec 16, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 10, 2024 •
edited
Loading

Description

changes made

  • moved v2_token_util to common models
  • created raw TokenOwnershipV2 and CurrentTokenOwnershipV2
  • updated postgres processors.

This was referenced Dec 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@yuunlimm Graphite App
Copy link
Contributor Author

yuunlimm commented Dec 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm changed the title [parquet-sdk][token_v2] migrate token ownership table pt1 ] [parquet-sdk][token_v2] migrate token ownership table [pt1] Dec 10, 2024
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 4a7a975 to 7212d38 Compare December 10, 2024 23:42
yuunlimm
yuunlimm commented Dec 10, 2024
View reviewed changes
rust/processor/src/db/parquet/models/token_v2_models/v2_token_ownerships.rs
@@ -507,3 +508,108 @@ impl TokenOwnershipV2 {
Ok(None)
}
}

// // Copyright © Aptos Foundation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Didn't update this yet, have to decide how to handle lookups

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is handled in pt2 pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out portion is deleted in next PR. Leaving in to prevent having to remerge here.

@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 7212d38 to 1b91927 Compare December 10, 2024 23:46
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from f7d158f to 69d5c9b Compare December 10, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 1b91927 to bbe4e9c Compare December 10, 2024 23:53
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.49731% with 337 lines in your changes missing coverage. Please review.

Project coverage is 35.1%. Comparing base (0a2fef6) to head (09d3514).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../models/token_v2_models/raw_v2_token_ownerships.rs 33.1% 311 Missing ⚠️
...ust/processor/src/processors/token_v2_processor.rs 27.7% 26 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #637      +/-   ##
========================================
- Coverage   47.6%   35.1%   -12.6%     
========================================
  Files        227     228       +1     
  Lines      27125   27205      +80     
========================================
- Hits       12931    9556    -3375     
- Misses     14194   17649    +3455

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Dec 11, 2024
Merged
Merged
Merged
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from 69d5c9b to 3690bb3 Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from bbe4e9c to 6fba30b Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from 3690bb3 to 1e4e874 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 6fba30b to 4962105 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from 1e4e874 to ece7950 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 4962105 to 6d18a30 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from ece7950 to 5193ef9 Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 6d18a30 to 67e9ddd Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from 5193ef9 to e9d7817 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 67e9ddd to f146c09 Compare December 11, 2024 23:54
@yuunlimm yuunlimm mentioned this pull request Dec 12, 2024
Closed
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from e9d7817 to 5d501e4 Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from f146c09 to 85f18b4 Compare December 12, 2024 02:23
@yuunlimm yuunlimm marked this pull request as ready for review December 12, 2024 03:28
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch from 5d501e4 to c70afcd Compare December 12, 2024 03:30
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 85f18b4 to f8b375a Compare December 12, 2024 03:31
@yuunlimm yuunlimm requested a review from dermanyang December 12, 2024 05:42
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 branch 2 times, most recently from 6c21d80 to 4dd8e80 Compare December 16, 2024 16:38
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from f8b375a to d8088ef Compare December 16, 2024 16:49
@yuunlimm yuunlimm changed the base branch from 12-10-_parquet-sdk_token_v2_migrate_tokendatav2_and_currenttokendatav2 to main December 16, 2024 16:49
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from d8088ef to 09d3514 Compare December 16, 2024 19:41
@yuunlimm yuunlimm merged commit 22f92fc into main Dec 16, 2024
11 checks passed
@yuunlimm Graphite App
Copy link
Contributor Author

Merge activity

  • Dec 16, 2:56 PM EST: A user merged this pull request with Graphite.

@yuunlimm yuunlimm deleted the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch December 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dermanyang dermanyang dermanyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuunlimm @dermanyang