-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parquet-sdk][token_v2] migrate token_v2_pending_claims #630
[parquet-sdk][token_v2] migrate token_v2_pending_claims #630
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
- Coverage 48.3% 48.0% -0.4%
=======================================
Files 214 218 +4
Lines 26397 26651 +254
=======================================
+ Hits 12776 12800 +24
- Misses 13621 13851 +230 ☔ View full report in Codecov by Sentry. |
bdf9888
to
8cebf59
Compare
62f4f5d
to
c5d9517
Compare
8cebf59
to
60cc57a
Compare
c5d9517
to
57939ca
Compare
60cc57a
to
11a7977
Compare
bbe748a
to
cd3e983
Compare
11a7977
to
106eb92
Compare
cd3e983
to
2a9cecd
Compare
106eb92
to
24ace6a
Compare
2a9cecd
to
fd497b9
Compare
24ace6a
to
b0aa109
Compare
fd497b9
to
adebbe3
Compare
b0aa109
to
36d1ed3
Compare
adebbe3
to
df57aee
Compare
36d1ed3
to
5e8bc02
Compare
df57aee
to
9f6a934
Compare
5e8bc02
to
08d3a8f
Compare
9f6a934
to
65d1db7
Compare
08d3a8f
to
c8f2719
Compare
65d1db7
to
8dfec13
Compare
c8f2719
to
789a402
Compare
8dfec13
to
b0c241b
Compare
b0c241b
to
9a5e0fc
Compare
) = parse_v2_token( | ||
&transactions.data, | ||
&table_handle_to_owner, | ||
&mut conn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going to pass these as none?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated in the ownership pr b/c that's where the query is made. this will be removed there
let backfill_table = set_backfill_table_flag(parquet_processor_config.backfill_table); | ||
// TODO: Update this | ||
let parquet_token_v2_extractor = | ||
ParquetTokenV2Extractor::new(backfill_table, 5, 500, self.db_pool.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come these values aren't taken from the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those were just placeholders, and this code is updated in the stacked pr as well
pub collection_id: String, | ||
} | ||
|
||
impl Ord for RawCurrentTokenPendingClaim { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought only the parquet models require Ord
and PartialOrd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort is done for raw models in the parsing logic
Description
TestPlan
ran both legacy and sdk postgres processor .. num of rows match for all three.