Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parquet-sdk][token_v2] migrate token_v2_pending_claims #630

Merged

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 10, 2024

Description

  • migrated pending claims

TestPlan

ran both legacy and sdk postgres processor .. num of rows match for all three.

Screenshot 2024-12-11 at 8 00 13 PM
Screenshot 2024-12-11 at 9 25 27 PM
Screenshot 2024-12-11 at 9 26 37 PM

Copy link
Contributor Author

yuunlimm commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 37.59591% with 244 lines in your changes missing coverage. Please review.

Project coverage is 48.0%. Comparing base (789a402) to head (9a5e0fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/parquet_processors/parquet_token_v2_processor.rs 0.0% 104 Missing ⚠️
...t_token_v2_processor/parquet_token_v2_extractor.rs 0.0% 74 Missing ⚠️
.../db/parquet/models/token_v2_models/token_claims.rs 0.0% 29 Missing ⚠️
.../common/models/token_v2_models/raw_token_claims.rs 84.2% 22 Missing ⚠️
...ust/processor/src/processors/token_v2_processor.rs 41.6% 7 Missing ⚠️
rust/sdk-processor/src/parquet_processors/mod.rs 0.0% 5 Missing ⚠️
...k-processor/src/config/indexer_processor_config.rs 0.0% 2 Missing ⚠️
rust/sdk-processor/src/config/processor_config.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #630     +/-   ##
=======================================
- Coverage   48.3%   48.0%   -0.4%     
=======================================
  Files        214     218      +4     
  Lines      26397   26651    +254     
=======================================
+ Hits       12776   12800     +24     
- Misses     13621   13851    +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from bdf9888 to 8cebf59 Compare December 10, 2024 20:09
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from 62f4f5d to c5d9517 Compare December 10, 2024 20:10
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 8cebf59 to 60cc57a Compare December 10, 2024 21:49
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from c5d9517 to 57939ca Compare December 10, 2024 21:49
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 60cc57a to 11a7977 Compare December 10, 2024 21:52
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch 2 times, most recently from bbe748a to cd3e983 Compare December 10, 2024 22:21
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 11a7977 to 106eb92 Compare December 11, 2024 21:02
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from cd3e983 to 2a9cecd Compare December 11, 2024 21:02
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 106eb92 to 24ace6a Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from 2a9cecd to fd497b9 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 24ace6a to b0aa109 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from fd497b9 to adebbe3 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from b0aa109 to 36d1ed3 Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from adebbe3 to df57aee Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 36d1ed3 to 5e8bc02 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from df57aee to 9f6a934 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 5e8bc02 to 08d3a8f Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from 9f6a934 to 65d1db7 Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-06-migrate_parquet_account_txn_processor_to_sdk branch from 08d3a8f to c8f2719 Compare December 12, 2024 03:16
@yuunlimm yuunlimm changed the base branch from 12-06-migrate_parquet_account_txn_processor_to_sdk to graphite-base/630 December 12, 2024 03:27
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from 65d1db7 to 8dfec13 Compare December 12, 2024 03:28
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from 8dfec13 to b0c241b Compare December 12, 2024 03:28
@yuunlimm yuunlimm changed the base branch from graphite-base/630 to main December 12, 2024 03:28
@yuunlimm yuunlimm marked this pull request as ready for review December 12, 2024 03:28
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch from b0c241b to 9a5e0fc Compare December 12, 2024 03:28
@yuunlimm yuunlimm requested a review from dermanyang December 12, 2024 05:26
) = parse_v2_token(
&transactions.data,
&table_handle_to_owner,
&mut conn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to pass these as none?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated in the ownership pr b/c that's where the query is made. this will be removed there

let backfill_table = set_backfill_table_flag(parquet_processor_config.backfill_table);
// TODO: Update this
let parquet_token_v2_extractor =
ParquetTokenV2Extractor::new(backfill_table, 5, 500, self.db_pool.clone());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these values aren't taken from the config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those were just placeholders, and this code is updated in the stacked pr as well

pub collection_id: String,
}

impl Ord for RawCurrentTokenPendingClaim {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought only the parquet models require Ord and PartialOrd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort is done for raw models in the parsing logic

@yuunlimm yuunlimm merged commit 59fbafe into main Dec 13, 2024
11 checks passed
@yuunlimm yuunlimm deleted the 12-09-_parquet-sdk_token_v2_migrate_token_v2_pending_claims branch December 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants