Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parquet-sdk][token_v2] migrate TokenActivityV2 #635

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 10, 2024

Description

  • added Raw TokenActivityV2
  • migrated TokenActivityV2

TestPlan

  • Compared the number of rows from DE teams BigQuery table, testing BigQuery table, legacy processor table, and sdk processor table

DE teams BigQuery table

Screenshot 2024-12-11 at 7 54 48 PM ### Legacy and sdk posrgres processor

Screenshot 2024-12-11 at 7 54 51 PM

parquet test table

Screenshot 2024-12-11 at 9 33 40 PM

Copy link
Contributor Author

yuunlimm commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 71.91011% with 100 lines in your changes missing coverage. Please review.

Project coverage is 47.8%. Comparing base (69c6d56) to head (5fb6366).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../models/token_v2_models/raw_v2_token_activities.rs 83.5% 45 Missing ⚠️
...quet/models/token_v2_models/v2_token_activities.rs 0.0% 27 Missing ⚠️
...t_token_v2_processor/parquet_token_v2_extractor.rs 0.0% 12 Missing ⚠️
...ust/processor/src/processors/token_v2_processor.rs 30.0% 7 Missing ⚠️
rust/sdk-processor/src/parquet_processors/mod.rs 0.0% 5 Missing ⚠️
...c/parquet_processors/parquet_token_v2_processor.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #635     +/-   ##
=======================================
- Coverage   47.9%   47.8%   -0.1%     
=======================================
  Files        222     224      +2     
  Lines      26796   26873     +77     
=======================================
+ Hits       12841   12866     +25     
- Misses     13955   14007     +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 1b8deff to bc9f22f Compare December 10, 2024 20:10
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 04cdd33 to 9d696b3 Compare December 10, 2024 20:10
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from bc9f22f to f8acbf3 Compare December 10, 2024 21:49
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 9d696b3 to 8ec8c22 Compare December 10, 2024 21:49
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from f8acbf3 to 5d0aaab Compare December 10, 2024 21:52
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 8ec8c22 to 89d4083 Compare December 10, 2024 21:52
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 5d0aaab to 02d140e Compare December 10, 2024 22:21
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 89d4083 to 1e88d0b Compare December 10, 2024 22:21
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 02d140e to 010dc55 Compare December 10, 2024 23:52
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 1e88d0b to db30b8a Compare December 10, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 010dc55 to 940261c Compare December 11, 2024 21:02
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from db30b8a to 610b02c Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 940261c to 0ce18b6 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 610b02c to 136dcaf Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 0ce18b6 to 8b3189b Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 136dcaf to d9654f1 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 8b3189b to 839a93f Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from d9654f1 to 6eadf7a Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 839a93f to f80f6c1 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 6eadf7a to 2448db8 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from f80f6c1 to 1e20a19 Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 2448db8 to a80d5d2 Compare December 12, 2024 02:23
@yuunlimm yuunlimm marked this pull request as ready for review December 12, 2024 03:28
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 1e20a19 to 613331f Compare December 12, 2024 03:29
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from a80d5d2 to da99b1b Compare December 12, 2024 03:29
@yuunlimm yuunlimm requested a review from dermanyang December 12, 2024 05:36
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata branch from 613331f to 9e21256 Compare December 13, 2024 20:09
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from da99b1b to 7829964 Compare December 13, 2024 21:40
@yuunlimm yuunlimm changed the base branch from 12-09-_parquet-sdk_token_v2_migrate_currenttokenv2metadata to main December 13, 2024 21:40
@yuunlimm yuunlimm force-pushed the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch from 7829964 to 5fb6366 Compare December 13, 2024 23:27
@yuunlimm yuunlimm merged commit 676f4e8 into main Dec 14, 2024
9 checks passed
@yuunlimm yuunlimm deleted the 12-09-_parquet-sdk_token_v2_migrate_tokenactivityv2 branch December 14, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants