Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate parquet txn metadata processor to sdk #625

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 5, 2024

Description

as said above

Test Plan

Screenshot 2024-12-05 at 2 42 18 PM Screenshot 2024-12-05 at 2 36 22 PM Screenshot 2024-12-05 at 2 36 20 PM Screenshot 2024-12-05 at 2 36 18 PM Screenshot 2024-12-05 at 2 36 17 PM

@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 21d8103 to 6052d0f Compare December 5, 2024 22:41
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from 29ce12b to 69a1b32 Compare December 5, 2024 22:41
@yuunlimm yuunlimm marked this pull request as ready for review December 5, 2024 22:49
@yuunlimm yuunlimm requested review from rtso, dermanyang and a team December 5, 2024 22:49
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0.60606% with 164 lines in your changes missing coverage. Please review.

Project coverage is 20.4%. Comparing base (691d748) to head (c468b4c).
Report is 1 commits behind head on 11-26-add_sdk_version_of_parquet_fa_processor.

Files with missing lines Patch % Lines
...ocessors/parquet_transaction_metadata_processor.rs 0.0% 101 Missing ⚠️
...ocessors/parquet_transaction_metadata_processor.rs 0.0% 28 Missing ⚠️
...rocessor/parquet_transaction_metadata_extractor.rs 0.0% 26 Missing ⚠️
rust/sdk-processor/src/parquet_processors/mod.rs 0.0% 5 Missing ⚠️
...k-processor/src/config/indexer_processor_config.rs 0.0% 3 Missing ⚠️
rust/sdk-processor/src/config/processor_config.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                                @@
##           11-26-add_sdk_version_of_parquet_fa_processor    #625      +/-   ##
================================================================================
- Coverage                                           48.9%   20.4%   -28.6%     
================================================================================
  Files                                                208     210       +2     
  Lines                                              26080   26223     +143     
================================================================================
- Hits                                               12774    5354    -7420     
- Misses                                             13306   20869    +7563     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dermanyang dermanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes to models except for factoring out the process_transactions logic. Looks good

@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 6052d0f to e3cae01 Compare December 6, 2024 19:52
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from 69a1b32 to 19cb208 Compare December 6, 2024 19:52
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from e3cae01 to 04df416 Compare December 6, 2024 20:12
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from 19cb208 to 3bc956d Compare December 6, 2024 20:12
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 04df416 to 199c214 Compare December 6, 2024 20:38
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from 3bc956d to b6dfdc6 Compare December 6, 2024 20:38
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 199c214 to e1a76bf Compare December 10, 2024 20:09
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch 3 times, most recently from a61e32f to ecfeae8 Compare December 10, 2024 21:52
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from e1a76bf to 606aaf2 Compare December 11, 2024 21:02
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from ecfeae8 to cc6872f Compare December 11, 2024 21:02
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 606aaf2 to a8dbcce Compare December 11, 2024 21:06
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch 2 times, most recently from 877caaf to f5f38f0 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from a8dbcce to 0a38d17 Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from f5f38f0 to d49cc2e Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 11-26-add_sdk_version_of_parquet_fa_processor branch from 0a38d17 to fb4b270 Compare December 11, 2024 23:53
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from d49cc2e to 764a852 Compare December 11, 2024 23:53
Base automatically changed from 11-26-add_sdk_version_of_parquet_fa_processor to main December 12, 2024 00:51
@yuunlimm yuunlimm force-pushed the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch from 764a852 to c468b4c Compare December 12, 2024 02:23
@yuunlimm yuunlimm changed the base branch from main to 11-26-add_sdk_version_of_parquet_fa_processor December 12, 2024 02:23
@yuunlimm yuunlimm merged commit 6ceb6d8 into 11-26-add_sdk_version_of_parquet_fa_processor Dec 12, 2024
11 checks passed
@yuunlimm yuunlimm deleted the 12-05-migrate_parquet_txn_metadata_processor_to_sdk branch December 12, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants