Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parquet-sdk][token_v2] migrate token ownership table [pt2] #638

Merged

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Dec 11, 2024

Description

  • migrated token_ownership_v2

TestPlan

  • Compared the number of rows from DE teams BigQuery table, testing BigQuery table, legacy processor table, and sdk processor table

current_token_ownership_v2
Screenshot 2024-12-11 at 7 57 05 PM
BQ:
Screenshot 2024-12-11 at 9 18 10 PM
PQ
Screenshot 2024-12-11 at 7 54 00 PM

Copy link
Contributor Author

yuunlimm commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 13.94231% with 179 lines in your changes missing coverage. Please review.

Project coverage is 46.6%. Comparing base (22f92fc) to head (a0b8ae9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...quet/models/token_v2_models/v2_token_ownerships.rs 0.0% 48 Missing ⚠️
...t_token_v2_processor/parquet_token_v2_extractor.rs 0.0% 46 Missing ⚠️
...s/parquet_processors/parquet_token_v2_processor.rs 0.0% 31 Missing ⚠️
...ust/processor/src/processors/token_v2_processor.rs 51.1% 21 Missing ⚠️
.../models/token_v2_models/raw_v2_token_ownerships.rs 17.6% 14 Missing ⚠️
rust/sdk-processor/src/parquet_processors/mod.rs 0.0% 10 Missing ⚠️
...c/parquet_processors/parquet_token_v2_processor.rs 0.0% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #638     +/-   ##
=======================================
- Coverage   47.7%   46.6%   -1.1%     
=======================================
  Files        228     228             
  Lines      27205   26964    -241     
=======================================
- Hits       12983   12580    -403     
- Misses     14222   14384    +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from bbe4e9c to 6fba30b Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 6bfefc8 to 2cf9dfd Compare December 11, 2024 21:03
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 6fba30b to 4962105 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 2cf9dfd to 6349351 Compare December 11, 2024 21:07
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 4962105 to 6d18a30 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 6349351 to 4993938 Compare December 11, 2024 22:18
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 6d18a30 to 67e9ddd Compare December 11, 2024 23:42
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 4993938 to 1b4a395 Compare December 11, 2024 23:43
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 67e9ddd to f146c09 Compare December 11, 2024 23:54
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 1b4a395 to ef3609f Compare December 11, 2024 23:54
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from f146c09 to 85f18b4 Compare December 12, 2024 02:23
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from ef3609f to d448651 Compare December 12, 2024 02:23
@yuunlimm yuunlimm marked this pull request as ready for review December 12, 2024 03:29
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ branch from 85f18b4 to f8b375a Compare December 12, 2024 03:31
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch 2 times, most recently from 846e23c to 979c1b8 Compare December 12, 2024 03:47
@yuunlimm yuunlimm changed the base branch from 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt1_ to main December 12, 2024 03:47
@yuunlimm yuunlimm requested a review from dermanyang December 12, 2024 05:42
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch 2 times, most recently from 16f4323 to 84a6dff Compare December 16, 2024 17:05
@yuunlimm yuunlimm force-pushed the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch from 84a6dff to a0b8ae9 Compare December 16, 2024 20:28
@yuunlimm yuunlimm merged commit e3ac2e9 into main Dec 16, 2024
11 checks passed
Copy link
Contributor Author

Merge activity

  • Dec 16, 4:32 PM EST: A user merged this pull request with Graphite.

@yuunlimm yuunlimm deleted the 12-10-_parquet-sdk_token_v2_migrate_token_ownership_table_pt2_ branch December 16, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants