Release v0.18.4 #3113
Merged
Release v0.18.4 #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/values-b+zh+HANS+CN was updated. Action: copy file in /values-b+zh+HANS+CN to /values-zh-rCN
This allows fixing spurious playback resume when minimizing to the background player.
* add missing namespace of StandardCharsets * use an unused constructor argument
This is a hardly reproduceable bug that I hopefully fixed. After a long time of watching videos, you could have your system language shown in playback parameters dialog. Calling changeAppLanguage(getAppLocale(…),…) onCreate will most certainly fix this bug
After long clicking on a local playlist, show a dialog with 2 options for "rename" and "delete" Rename shows another dialog to let the user rename the playlist. Delete lets the user delete a playlist like before.
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 99.8% (526 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 98.5% (519 of 527 strings)
|
upps. |
|
@Poolitzer fixed about #3102 ;-) |
|
Good. I assumed that, so I moved it in the blogpost already (not that it matters this much) |
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 99.6% (530 of 532 strings)
Currently translated at 99.6% (530 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 93.0% (495 of 532 strings)
Currently translated at 28.5% (152 of 532 strings)
Multiple localization fixes
B0pol
requested changes
Feb 21, 2020
There was a problem hiding this comment.
f089cd0
I deleted live_duration_button translatable="false", and used live_duration instead, which is translatable.
All live_duration_button strings should be deleted (by ctrl-Fing in source, I find: values- cs, in, he, pl, ku, zh-rTW, tr).
I checked, for all of the quoted languages, live_duration is already translated so you can delete safely live_duration_button
|
@TobiGr No, I don't think so, we should be good (the apk works and no problem has been reported) :-) |
|
What the hell is going on. 👀 I cannot push to the dev branch. Worked without problems some minutes ago. Now I send endless data to GitHub, but nothing happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Improved
Fixed
.srtsubtitle downloads containing not all line breaks Rewrite ttml conversion #2957.mp4file being recognized as audio file mp4 muxer fix #2959TODO
APK for testing: RC1
app-debug_RC1.zip
PLEASE REPORT NEW CRASHES IN THE CORRESPONDING ISSUE #3114