Spelling: Language reworked 2 #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Jan 8, 2020
| <string name="download_path_audio_title">Audio download folder</string> | ||
| <string name="download_path_audio_summary">Downloaded audio files are stored here</string> | ||
| <string name="download_path_audio_dialog_title">Choose the download folder for audio files</string> | ||
| <string name="download_path_audio_dialog_title">Choose download folder for audio files</string> | ||
| <string name="download_choose_new_path">Change the download folders to take effect</string> |
There was a problem hiding this comment.
I am not sure what happens here.
There was a problem hiding this comment.
I'm assuming this is the prompt that asks which file you want to save downloaded audio in.
There was a problem hiding this comment.
Yes. NewPipe allows people to set different download folders for audio and video downloads.
There was a problem hiding this comment.
I meant the "Change the download folders to take effect"…?
comradekingu
commented
Jan 8, 2020
TobiGr
suggested changes
Jan 9, 2020
| <string name="download_path_audio_title">Audio download folder</string> | ||
| <string name="download_path_audio_summary">Downloaded audio files are stored here</string> | ||
| <string name="download_path_audio_dialog_title">Choose the download folder for audio files</string> | ||
| <string name="download_path_audio_dialog_title">Choose download folder for audio files</string> | ||
| <string name="download_choose_new_path">Change the download folders to take effect</string> |
There was a problem hiding this comment.
Yes. NewPipe allows people to set different download folders for audio and video downloads.
comradekingu
commented
Jan 9, 2020
cool-student
reviewed
Jan 9, 2020
cool-student
reviewed
Jan 9, 2020
cool-student
reviewed
Jan 9, 2020
cool-student
suggested changes
Jan 9, 2020
TobiGr
added
the
localisation / translation
comradekingu
commented
Jan 20, 2020
TobiGr
reviewed
Feb 6, 2020
|
@comradekingu Please grant us maintainers permission to the PR's branch so we can fix the last two things and merge afterwards. |
Co-Authored-By: Tobias Groza <[email protected]>
comradekingu
commented
Feb 7, 2020
comradekingu
commented
Feb 7, 2020
comradekingu
commented
Feb 7, 2020
comradekingu
commented
Feb 7, 2020
TobiGr
suggested changes
Feb 7, 2020
Stypox
reviewed
Feb 9, 2020
Co-Authored-By: Stypox <[email protected]>
Stypox
requested changes
Feb 16, 2020
Co-Authored-By: Stypox <[email protected]>
TobiGr
approved these changes
Feb 16, 2020
|
@Stypox In my eyes this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some savings, structure, consistency.