Release v0.18.4 #3114

Stypox · 2020-02-19T19:53:08Z

New

Added language selector to change the app language Add language selector to change the app language #2921
Added send to Kodi button to player collapsible menu Add send to Kodi button to player next to share button #2310
Added ability to copy comments on long press added ability to copy comments on long press #3053

Improved

Fix ReCaptcha activity and correctly save obtained cookies Fix ReCaptcha activity and correctly save obtained cookies #3035
Remove dot-menu in favour of drawer and hide history button when "Watch history" is not enabled in settings Remove dot-menu where not required; Issue #2254 #2960
Ask for display over other apps permission in settings correctly on Android 6 and later ask for display over other apps permission in settings #3004
Rename local playlist by long-clicking in BookmarkFragment Rename local playlist by long-clicking in BookmarkFragment. #2954
Various PeerTube improvements Description fix and some PeerTube fixes #3044 :
- Display full description instead of truncated
- Handle age limit
Improved several English source strings Spelling: Language reworked 2 #2938

Fixed

Fixed player starting again although it is paused when option "minimize on app switch" enabled and NewPipe is minimized Allow a BasePlayer to start paused #2917
Fixed .srt subtitle downloads containing not all line breaks Rewrite ttml conversion #2957
Fixed download to SD card failing because some Android 5 devices are not CTF compliant fix #2889 #2958
Fixed downloading on Android KitKat Fixes #3021 #3032
Fixed corrupt video .mp4 file being recognized as audio file mp4 muxer fix #2959
Fixed wrong Chines language codes Fix wrong lang code of Chinese,and clean up useless strings.xml #2865
Fix initial brightness value for gesture Fix initial brightness value #3102
Fixed corrupt mp4 downloads fixup for #3081 #3117
[YouTube] Timestamps in description are clickable again Description fix and some PeerTube fixes #3044

APK for testing: RC1

app-debug_RC1.zip
PULL REQUEST #3113

PLEASE REPORT ONLY NEW BUGS BELOW

The text was updated successfully, but these errors were encountered:

Stypox · 2020-02-19T19:58:28Z

@TobiGr should I also add NewPipeExtractor changelog here?

Stypox · 2020-02-20T06:17:25Z

@aaazv no, we don't have a Telegram group, see #2965
Recaptchas have been fixed in this version. Please post here only new issues you find in the provided RC apk.

@garawaa that's not a new bug related to this release and to the provided RC apk, but is just a feature request. There are already issues open for it.

cool-student · 2020-02-20T07:31:55Z

@Stypox
~~I think we should merge #3099 since it fixes a regression introduced in #2959~~
thanks

TobiGr · 2020-02-20T09:44:42Z

@TobiGr should I also add NewPipeExtractor changelog here?

@Stypox No. Thank you for taking care of this release. I have a changelog file, but I am waiting for #3098 and #3099 before I push it. Btw, please create a new branch for a release as described in the our docs next time. I forgot to point that out yesterday :)

aaazv · 2020-02-20T23:42:28Z

Can u tell me when will this be released?

Poolitzer · 2020-02-21T01:05:50Z

if you need it now, download the debug apk

opusforlife2 · 2020-02-21T08:52:17Z

@aaazv Yep. As @Poolitzer said, you can use the debug APK if it's urgent. It will install separately from the main app, and you can continue to use the debug app until the new version is released officially.

aaazv · 2020-02-22T02:58:55Z

A problem.

As I close every app as "kill foreground app", whenever I try to open a utube video with newpipe again, the video doesnt come the first time. the forst attempt, the app shows up on the default page, what ever it is, then u have to click on the link again to see the video in newpipe.
I checked this with official app and its not like this.
Can u fix this that even if the app is closed from the base, when it opens with a link, to go directly to the link and not to the main page?

This bothers a little.
Another thing is that the videos dont load sometimes and the rest of the time, load slower than other apps.

But still, its better than vanced or snaptube or original app. thanks.

Poolitzer · 2020-02-22T04:21:28Z

How do you try to open it.

aaazv · 2020-02-22T04:37:38Z

By searching a video in google and clicking on a vid coming up in search results. Then it asks me to open woth chrome or newpipe, I choose newpipe.

This way, first the app starts without showing the content I want and I have to click on the link again and it shows the vid as the app has started now.

Stypox · 2020-02-22T08:22:34Z

@aaazv is this a new bug introduced by this release? If not, please open a new issue

Anyway, we would need the device model and OS, and it would help if you intercepted the "open" intent using Intent Intercept: https://f-droid.org/app/de.k3b.android.intentintercept

opusforlife2 · 2020-02-22T08:43:43Z

GUYS! REGRESSION!

Remove dot-menu in favour of drawer

I thought this setting would replace the dot menu with the drawer everywhere. Turns out that it just removes the dot menu. The drawer is only accessible from the home screen.

If you must remove the dot menu, please make the drawer accessible from all screens.

Edit: as an example, suppose you want to switch from WebM to MPEG-4 for a video, now you have to go all the way back to the home screen, change the setting, then search for the video again, losing all your back button history (I forgot what it's called).

B0pol · 2020-02-22T08:47:35Z

I don't think you need to access settings everywhere, why would you?

I've watched the behavior on some other app, and all are the same : you can only access drawer on main page. If you are in a subactivity (ie there is a back button in appbar), you can't access settings.

opusforlife2 · 2020-02-22T08:49:37Z

If you are in a subactivity (ie there is a back button in appbar), you can't access settings.

Not true. Play Store > My apps & games has the back button, yet the side drawer is accessible.

Anyway, why would you want to take functionality away from the user?

Stypox · 2020-02-22T09:07:57Z

@TobiGr what should we do about this menu issue? The only button needeed from everywhere is probably "Settings", so we could add it back.

opusforlife2 · 2020-02-22T09:12:08Z

I think there is nothing wrong with the direction this is going in. If you were to ask me what I preferred, dot menu or sidebar, I would choose sidebar. Is it difficult to make it accessible on other screens?

Stypox · 2020-02-22T10:19:46Z

I found an issue in this release: pressing "Switch to Popup" in the background player queue activity generates a crash. I tried to look into it but I was not able to understand why this happens and how to fix it. Switching to MainPlayer works, and switching from MainPlayer to other players works. @TobiGr

Exception

User Action: ui error
Request: App crash, UI failure
Content Language: en_GB
Service: none
Version: 0.18.4
OS: Linux Android 7.0 - 24

Crash log

android.content.ActivityNotFoundException: Unable to find explicit activity class {org.schabi.newpipe.debug/org.schabi.newpipe.player.PopupVideoPlayer}; have you declared this activity in your AndroidManifest.xml?
	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1850)
	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1544)
	at android.app.ContextImpl.startActivity(ContextImpl.java:885)
	at android.app.ContextImpl.startActivity(ContextImpl.java:855)
	at android.content.ContextWrapper.startActivity(ContextWrapper.java:356)
	at org.schabi.newpipe.player.ServicePlayerActivity.switchTo(ServicePlayerActivity.java:199)
	at org.schabi.newpipe.player.BackgroundPlayerActivity.onPlayerOptionSelected(BackgroundPlayerActivity.java:58)
	at org.schabi.newpipe.player.ServicePlayerActivity.onOptionsItemSelected(ServicePlayerActivity.java:171)
	at android.app.Activity.onMenuItemSelected(Activity.java:3356)
	at androidx.fragment.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:384)
	at androidx.appcompat.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:219)
	at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:109)
	at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:109)
	at androidx.appcompat.app.ToolbarActionBar$2.onMenuItemClick(ToolbarActionBar.java:64)
	at androidx.appcompat.widget.Toolbar$1.onMenuItemClick(Toolbar.java:207)
	at androidx.appcompat.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected(ActionMenuView.java:781)
	at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:840)
	at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
	at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:991)
	at androidx.appcompat.view.menu.MenuPopup.onItemClick(MenuPopup.java:128)
	at android.widget.AdapterView.performItemClick(AdapterView.java:313)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1201)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:3195)
	at android.widget.AbsListView$3.run(AbsListView.java:4138)
	at android.os.Handler.handleCallback(Handler.java:761)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:156)
	at android.app.ActivityThread.main(ActivityThread.java:6523)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:942)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:832)

opusforlife2 · 2020-02-22T10:22:46Z

pressing "Switch to Popup" in the background player queue activity generates a crash

Confirmed.

TobiGr · 2020-02-22T14:11:42Z

Uh. I guess this was introduced by #2917. I'll look into it tonight :(

See #3114 (comment) for info on this crash. This reverts ef90493 partly.

TobiGr · 2020-02-22T19:47:35Z

I reverted ef90493 partly in 0bc769b. This fixes the crash for me, but does not introduce the old buggy behaviour. Here is the last RC for this release: NewPipe_v0.18.4_RC3.zip
CC @opusforlife2 @Stypox

Stypox · 2020-02-22T19:57:53Z

Mmmh, strange, we will have to look into this after the release... Anyway, the apk works for me, thanks for looking into it :-).

opusforlife2 · 2020-02-22T20:30:51Z

Confirmed. Crash fixed. Release time!

opusforlife2 · 2020-02-22T20:59:31Z

By the way, @Stypox I downloaded mauricio's PR 2309 apk. He renamed the package. If you could encourage other PR authors to rename their apks as well, we could test multiple apks side by side without having to go through the hassle of uninstalling and reinstalling.

TobiGr · 2020-02-22T21:03:39Z

@opusforlife2 Good idea. We might want to add this information to the contribution guidelines and to the pull request teplate. Btw.. we should also create more issue templates. One for bug reports and one for feature requests

Stypox · 2020-02-22T21:11:19Z

Yeah, great idea. What about adding a ".branchname" at the end of the app signature, only if the current branch name is not "master" or "dev"? Also, we could set the app name to "NewPipe branchname" with the rules above. This should be doable with gradle.

Poolitzer · 2020-02-22T21:14:55Z

@TobiGr I wanted to do those templates anyway, can do that in a bit (after I updated the blog post)

TobiGr · 2020-02-22T22:57:29Z

New version is released.

Stypox mentioned this issue Feb 19, 2020

Release v0.18.4 #3113

Merged

4 tasks

Stypox pinned this issue Feb 19, 2020

Stypox added this to the 0.18.4 milestone Feb 19, 2020

This comment has been minimized.

Sign in to view

TobiGr mentioned this issue Feb 21, 2020

creating fastelane changelog #3119

Closed

1 task

Stypox mentioned this issue Feb 22, 2020

Reintroduce "Settings" button in app bar #3128

Merged

1 task

TobiGr added a commit that referenced this issue Feb 22, 2020

Fix regression: Unable to find explicit activity class

0bc769b

See #3114 (comment) for info on this crash. This reverts ef90493 partly.

TobiGr closed this as completed Feb 22, 2020

Stypox unpinned this issue Feb 23, 2020

Stypox mentioned this issue Feb 23, 2020

Change app id based on current git branch #3133

Merged

1 task

opusforlife2 mentioned this issue Feb 23, 2020

Make drawer accessible from every activity #3135

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.18.4 #3114

Release v0.18.4 #3114

Stypox commented Feb 19, 2020 •

edited

Loading

Stypox commented Feb 19, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Stypox commented Feb 20, 2020

cool-student commented Feb 20, 2020 •

edited

Loading

TobiGr commented Feb 20, 2020

aaazv commented Feb 20, 2020

Poolitzer commented Feb 21, 2020

opusforlife2 commented Feb 21, 2020

aaazv commented Feb 22, 2020 •

edited

Loading

Poolitzer commented Feb 22, 2020

aaazv commented Feb 22, 2020 •

edited

Loading

Stypox commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020 •

edited

Loading

B0pol commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

Stypox commented Feb 22, 2020 •

edited

Loading

opusforlife2 commented Feb 22, 2020

Stypox commented Feb 22, 2020 •

edited

Loading

opusforlife2 commented Feb 22, 2020

TobiGr commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Stypox commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Stypox commented Feb 22, 2020

Poolitzer commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Release v0.18.4 #3114

Release v0.18.4 #3114

Comments

Stypox commented Feb 19, 2020 • edited Loading

New

Improved

Fixed

APK for testing: RC1

PLEASE REPORT ONLY NEW BUGS BELOW

Stypox commented Feb 19, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Stypox commented Feb 20, 2020

cool-student commented Feb 20, 2020 • edited Loading

TobiGr commented Feb 20, 2020

aaazv commented Feb 20, 2020

Poolitzer commented Feb 21, 2020

opusforlife2 commented Feb 21, 2020

aaazv commented Feb 22, 2020 • edited Loading

Poolitzer commented Feb 22, 2020

aaazv commented Feb 22, 2020 • edited Loading

Stypox commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020 • edited Loading

B0pol commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

Stypox commented Feb 22, 2020 • edited Loading

opusforlife2 commented Feb 22, 2020

Stypox commented Feb 22, 2020 • edited Loading

Exception

opusforlife2 commented Feb 22, 2020

TobiGr commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Stypox commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

opusforlife2 commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Stypox commented Feb 22, 2020

Poolitzer commented Feb 22, 2020

TobiGr commented Feb 22, 2020

Stypox commented Feb 19, 2020 •

edited

Loading

cool-student commented Feb 20, 2020 •

edited

Loading

aaazv commented Feb 22, 2020 •

edited

Loading

aaazv commented Feb 22, 2020 •

edited

Loading

opusforlife2 commented Feb 22, 2020 •

edited

Loading

Stypox commented Feb 22, 2020 •

edited

Loading

Stypox commented Feb 22, 2020 •

edited

Loading