Multiple localization fixes #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the extractor PR, fixes title & description shown in the wrong language. Fixed views / spectators counts possibly in the wrong language Fixed live spectators not showing full count on detail page Fixed LIVE shown on players, it shows translated instead Fixed Videos string in search / three dots not available in Weblate (because it was videos, but there already was a plural string named videos, in Weblate) Subscriber count is always giving the short count. We can't get exact number since this YouTube update: https://support.google.com/youtube/thread/6543166 But only short count (B, M, k), so showing full number, eg for 1.9M: 1,900,000, is wrong because the number could be 1,923,490 or 1,897,789… Added a « sytem default » option to content language and country language selector. It's the one selected by default (not en-GB anymore then), and correspond to the language of the system / country of the system By system I mean phone, tablet, TV… Fixed russian showing - before time ago (eg 19hrs ago) This is a workaround fix, I opened an issue on prettytime library repo. Fixed russian plurals: other was used instead of many for videos and subscribers Fixed seek_duration english only
TobiGr
added
bug
TobiGr
reviewed
Feb 15, 2020
app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java
Outdated
Show resolved
Hide resolved
Stypox
requested changes
Feb 16, 2020
Stypox
previously approved these changes
Feb 16, 2020
|
I need to remove the extractor version change first. And this could be merged before the extractor pr, I just used this to test at the same time, but they are not dependent. Edit: removed the extractor commit |
mauriciocolli
suggested changes
Feb 16, 2020
if somehow your module name isn't app, it will create a module-name.iml file, and isn't needed
B0pol
commented
Feb 18, 2020
Stypox
requested changes
Feb 19, 2020
Co-Authored-By: Stypox <[email protected]>
Closed
TobiGr
reviewed
Feb 20, 2020
TobiGr
approved these changes
Feb 20, 2020
Stypox
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Looks good to me, thanks!
I will merge this in the evening @mauriciocolli ;-)
|
@TobiGr I am not able to merge, I cannot dismiss @mauriciocolli's review even though the changes he requested have been addressed |
|
@Stypox Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I fixed all the remaining translation related issues on NewPipe, except #2124 (someone with Weblate rigths have to do it).
Changelog
Added a « sytem default » option to content language and country language selector (#1132) It's the one selected by default (not en-GB anymore then), and correspond to the language of the system / country of the system By system I mean phone, tablet, TV…Fixed russian showing - before time ago (eg 19hrs ago) (#2894)
This is a workaround fix, I opened an issue on prettytime library repo.
ocpsoft/prettytime#182
Fixed russian plurals (#1588)
other was used instead of many for videos and subscribers
Fixed seek_duration english only (#3025)
Fixed views / spectators counts possibly in the wrong language (Bugfix)
Fixed live spectators not showing full count on detail page
Fixed LIVE shown on players, it shows translated instead
Fixed Videos string in search / three dots not available in Weblate (Bugfix)
(because it was videos, but there already was a plural string named videos, in Weblate)
Subscriber count is always giving the short count (Improvement)
We can't get exact number since this YouTube update: https://support.google.com/youtube/thread/6543166
But only short count (B, M, k), so showing full number, eg for 1.9M: 1,900,000, is wrong because the number could be 1,923,490 or 1,897,789…