Fix initial brightness value

[vhsw]

• I carefully read the contribution guidelines and agree to them.
  Fixes Brightness resets on first gesture brightness change after playback activity open #3084

[Stypox]

Are you sure that getWindow().getAttributes().screenBrightness is in range [0.0, 1.0]? The reference says:

A value of less than 0, the default, means to use the preferred screen brightness. 0 to 1 adjusts the brightness from dark to full bright.

According to this Stack Overflow question:

settings.screenBrightness will return -1 if it has not been previously overwritten in code. This is correct behaviour as setting screenBrightness to -1 will set the brightness to the current system brightness level.

Current brightness can be retrieved by getWindow().getAttributes().screenBrightness. If however this current brightness is < 0 this means that application uses the current settings for brightness (which can be loaded by the means provided in current answer)

So we should check for getWindow().getAttributes().screenBrightness first, and if it is negative use this, instead:

    float curBrightnessValue=android.provider.Settings.System.getInt(
    getContentResolver(), android.provider.Settings.System.SCREEN_BRIGHTNESS) / 255.0f;

[Stypox]

This should be good now, thanks!

[Stypox]

Could you provide a test apk?

[vhsw]

Here is the test apk

app-debug.zip

[Stypox]

I tested the app and it works as expected. Thank you @vhsw ! :-D
@TobiGr I am merging this even though it is not in the milestone since it is a simple change

[TobiGr]

@Stypox If you have time, can you please create a RC and create a PR + Issue? I'd like to release a new version as soon as possible, but the time I can spend on NewPipe is quite limited the next two weeks.

[wb9688]

@TobiGr: I'd wait until yt_new is finished. Tomorrow I probably have another 4 hours and them I'm hopefully much more productive.

[Stypox]

@TobiGr I don't have the keys to sign a release RC, so I'm just going to build a Debug RC apk, is that ok?
I assume the way to build RCs is exactly the same as the way to build normal debug apks, isnt't?
The PR has to be created between the dev and the master branch, hasn't it?
Also, would #3098 be postponed to 0.18.5?

@wb9688 Ok, even though it could have some problems at the beginning since it is not thoroughly tested. But we will test using RCs, so that's ok. Thank you :-)

[TobiGr]

@Stypox For the RC, I use my debug key, too. I'd wait for mauricio's review of #3098. If he does not answer until Friday, I assume it is good to merge and will be included in the 0.18.4.

Regarding the new YouTube version: we should release it asap, but not in 0.18.4. We still have 11 days and can release 0.18.5 as soon as the extractor is stable.

[Stypox]

I will create the PR&issue later today or tomorrow (I have to study ;-) )