Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plurals problem in Russian #1588

Closed
bboa opened this issue Aug 6, 2018 · 4 comments · Fixed by #3098
Closed

Plurals problem in Russian #1588

bboa opened this issue Aug 6, 2018 · 4 comments · Fixed by #3098
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate

Comments

@bboa
Copy link
Contributor

bboa commented Aug 6, 2018

Dear friends, last build have some plurals problems: https://imgur.com/a/m0VryaY

Explanation for screenshot:

str. 2 "6 тыс. подписчика" - expected "many", current "few",
str. 4 "56 тыс. подписчик" - expected "many", current "one".

As I see, the plurals section in strings.xml are correct. How we can help to fix this?

@theScrabi
Copy link
Member

You could take a look at our weblate.org translation page. Maybe the plurals are wrong there. Also app/src/res/values/strings-ru.xml could help you.

@bboa
Copy link
Contributor Author

bboa commented Aug 8, 2018

hmm, I just check Weblate template and he is also correct, so probably it's a more wide problem, maybe other languages affected too.

I can bypass this by shortening words in translation, but not sure that it's a good idea.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@TobiGr TobiGr removed the stale label Jul 19, 2019
@bboa
Copy link
Contributor Author

bboa commented Aug 26, 2019

Hey! Now I understand.

We have two different view counters.
The one is placed on video details screen, under big thumbnail. It always contains an exact views value, e. g. "194,541 views" and works correctly.

The other is placed on videos list, on right side from little video thumbnails. This counter works dinamically, and here is a problem. If views count is less than 1000, this counter displays exact views count, e.g. "741 views", and all work perfectly too.

But, if views count is more than 999, this counter displays approximate value, e.g. 1K, 2M, 127K etc. And, here is a problem: if we have 194,541 views, in Russian, because last digit is 1, here will be used word form, equal to English "view", not "wiews". But this second counter will be displayed as "194K view", is a English translated eqivalent. Same problem will be reproduced, if exact views count will have last digits as 1, 2, 3, 4, e. g. in 40% cases, for Russian UI.

Looks like for second counter we need to add additional checking to fix non-English UI behaviour, if views count is more than 999 and contains approximated value, then plurals word form (like "views") will be always used, I hope that it's right for all languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants