Description fix and some PeerTube fixes #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
added
bug
yausername
reviewed
Feb 6, 2020
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
description: - PeerTube: it's now full description (it cut at 250 characters before), and it displays ok (newlines are ok, but markdown isn't) - MediaCCC: descriptions are now displayed well (newlines added) - YouTube: timestamps in descriptions are clickable and work more PeerTube fixes: thumbnail is now high quality age limit is now handled upload date in «recently added» feed is good now (it was one hour delayed) all fixes come from TeamNewPipe/NewPipeExtractor#239, so it need to be merged before this PR
yausername
reviewed
Feb 7, 2020
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
yausername
reviewed
Feb 8, 2020
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
and update third-party licences in about page
yausername
previously approved these changes
Feb 8, 2020
|
Thanks for updating the used libraries. |
|
Done. @TobiGr |
TobiGr
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PeerTube fixes:
Screenshots & APK
Before
After: Thumbnail Description (and see this beautiful Markdown 😃)
APK: 2020-02-08_description_and_peertube_fixes#3044.zip
Other
TeamNewPipe/NewPipeExtractor#239, needs to be merged before this PR.
As mentionned here (comment), I plan to make a second PR later to implement metadata extracted thanks to TeamNewPipe/NewPipeExtractor#239, but this PR is only made of fixes so that it can be hopefully in the next version.