-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to copy comments on long press #3053
Conversation
I don't think we need a settings option for this feature unless it is causing some performance hit. |
ok i'll remove it |
How it works? Is it like description, you can select the area you want, or it copy the whole description? |
it copies the whole comment. i actually wanted to make it so that you can select the text, but the root view of the comment is clickable, so the the textview isn't selectable. |
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: yausername <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Added ability to copy comments on long pressing them, and entry in the settings to enable/disable it.