Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to copy comments on long press #3053

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

harshlele
Copy link
Contributor

Added ability to copy comments on long pressing them, and entry in the settings to enable/disable it.

@yausername
Copy link
Contributor

I don't think we need a settings option for this feature unless it is causing some performance hit.
We don't want to have a bloated settings menu.

@harshlele
Copy link
Contributor Author

ok i'll remove it

@B0pol
Copy link
Member

B0pol commented Feb 4, 2020

How it works? Is it like description, you can select the area you want, or it copy the whole description?

@harshlele
Copy link
Contributor Author

it copies the whole comment. i actually wanted to make it so that you can select the text, but the root view of the comment is clickable, so the the textview isn't selectable.

Copy link
Contributor

@yausername yausername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.

@TobiGr TobiGr added this to the 0.18.3 milestone Feb 6, 2020
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@TobiGr TobiGr merged commit 487952f into TeamNewPipe:dev Feb 6, 2020
This was referenced Feb 19, 2020
@B0pol B0pol mentioned this pull request Jun 10, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants