Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show "History" in context menu if "History & Cache" disabled in "Settings" #2254

Closed
2 of 3 tasks
ghost opened this issue Mar 30, 2019 · 6 comments · Fixed by #2960
Closed
2 of 3 tasks

Do not show "History" in context menu if "History & Cache" disabled in "Settings" #2254

ghost opened this issue Mar 30, 2019 · 6 comments · Fixed by #2960
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented Mar 30, 2019

pic.1

pic.2

@TobiGr
Copy link
Contributor

TobiGr commented Apr 27, 2019

I think the whole menu can be removed as its content is available through the navigation drawer. @theScrabi Is there a reason why it has not been removed yet?

@Stypox Stypox added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Sep 27, 2019
@ghost
Copy link

ghost commented Jan 13, 2020

Hey, I would like to make this one (as my first-ever OS issue). Is it still available?

@Stypox Stypox changed the title Do not show "History" in context menu if "History & Cash" disabled in "Settings" Do not show "History" in context menu if "History & Cache" disabled in "Settings" Jan 13, 2020
@Stypox
Copy link
Member

Stypox commented Jan 13, 2020

Yeah, this is still available @karkaminski
What needs to be done is removing the duplicate three-dot menu and disable the History button in the navigation drawer when the user asked not to store history.
Feel free to ask any question, and thank you :-D

@ghost
Copy link

ghost commented Jan 14, 2020

(I think) I completed the task but need support with git-stuff ;)
This is what I've done so far:

  1. Forked and cloned NewPipe repo
  2. Created new branch (name: issue-Do not show "History" in context menu if "History & Cache" disabled in "Settings" #2254)
  3. Completed the task: removed dot-menu where it is no longer needed and implemented disabling History button according to settings
  4. commited (2 commits) and pushed to github
    What should I do next...? :)

@Stypox
Copy link
Member

Stypox commented Jan 14, 2020

Go to your branch on GitHub and click on the "Pull request" button just above the file browser @karkaminski

@mauriciocolli
Copy link
Contributor

If this is to be kept, maybe we should think about making the navigation drawer available application-wide as well?

Very annoying that you have to quit everything for changing a single setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants