Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Microsoft.ContainerService api-version 2020-03-01 #8756

Merged

Conversation

xizha162
Copy link
Contributor

@xizha162 xizha162 commented Mar 18, 2020

We would like to publish 2020-03-01 api version for Microsoft.ContainerService. Here is a list of all the PRs included in the dev branch:

All the PRs to dev branch has been reviewed and signed off by the SDK team and ARM team.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Xiaofang Zhang and others added 8 commits February 17, 2020 11:54
* added sku to managed cluster api

* move managedcluster sku data model location
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 18, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from a090a07 with merge commit 08c4662. SDK Automation 13.0.17.20200320.2
  • ⚠️containerservice/mgmt/2017-07-01 [Logs
      No file is changed.
    • ⚠️containerservice/mgmt/2017-08-31 [Logs
        No file is changed.
      • ⚠️containerservice/mgmt/2017-09-30 [Logs
          No file is changed.
        • ⚠️containerservice/mgmt/2018-03-31 [Logs
            No file is changed.
          • ⚠️containerservice/mgmt/2019-02-01 [Logs
              No file is changed.
            • ⚠️containerservice/mgmt/2019-04-30 [Logs
                No file is changed.
              • ⚠️containerservice/mgmt/2019-06-01 [Logs
                  No file is changed.
                • ⚠️containerservice/mgmt/2019-08-01 [Logs
                    No file is changed.
                  • ⚠️containerservice/mgmt/2019-10-01 [Logs
                      No file is changed.
                    • ⚠️containerservice/mgmt/2019-11-01 [Logs
                        No file is changed.
                      • ⚠️containerservice/mgmt/2020-01-01 [Logs
                          No file is changed.
                        • ⚠️containerservice/mgmt/2020-02-01 [Logs
                            No file is changed.
                          • ️✔️containerservice/mgmt/2020-03-01 [Logs]  [Release SDK Changes]
                          • ⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs
                              No file is changed.
                            • ⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs
                                No file is changed.
                              • ⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs
                                  No file is changed.
                                • ⚠️preview/containerservice/mgmt/2019-10-27-preview [Logs
                                    No file is changed.

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Mar 18, 2020

                                  azure-sdk-for-js - Release

                                  ️✔️ succeeded [Logs] [Expand Details]

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Mar 18, 2020

                                  azure-cli-extensions - Release

                                  No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Mar 18, 2020

                                  azure-sdk-for-java - Release

                                  ️✔️ succeeded [Logs] [Expand Details]

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Mar 18, 2020

                                  azure-sdk-for-net - Release

                                  ️✔️ succeeded [Logs] [Expand Details]

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Mar 18, 2020

                                  azure-sdk-for-python - Release

                                  - Breaking Change detected in SDK

                                  ⚠️ warning [Logs] [Expand Details]
                                  • ⚠️ Generate from a090a07 with merge commit 08c4662. SDK Automation 13.0.17.20200320.2
                                  • ⚠️azure-mgmt-containerservice [Logs]  [Release SDK Changes] Breaking Change Detected
                                    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
                                    [after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
                                    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                    [build_package]   warnings.warn(msg)
                                    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                    [build_package]   warnings.warn(msg)
                                    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                                    [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                                    [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                                    [ChangeLog] Size of delta 5.336% size of original (original: 55754 chars, delta: 2975 chars)
                                    [ChangeLog] **Features**
                                    [ChangeLog] 
                                    [ChangeLog] - Model OpenShiftManagedClusterMasterPoolProfile has a new parameter api_properties
                                    [ChangeLog] - Model ManagedClusterAADProfile has a new parameter managed
                                    [ChangeLog] - Model ManagedClusterAADProfile has a new parameter admin_group_object_ids
                                    [ChangeLog] - Model OpenShiftManagedCluster has a new parameter refresh_cluster
                                    [ChangeLog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter mode
                                    [ChangeLog] - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter balance_similar_node_groups
                                    [ChangeLog] - Model AgentPool has a new parameter mode
                                    [ChangeLog] - Model ManagedCluster has a new parameter sku
                                    [ChangeLog] - Model ManagedClusterAgentPoolProfile has a new parameter mode
                                    [ChangeLog] - Model NetworkProfile has a new parameter management_subnet_cidr
                                    [ChangeLog] 
                                    [ChangeLog] **Breaking changes**
                                    [ChangeLog] 
                                    [ChangeLog] - Model OpenShiftManagedClusterMasterPoolProfile no longer has parameter name
                                    [ChangeLog] - Model OpenShiftManagedClusterMasterPoolProfile no longer has parameter os_type
                                    [ChangeLog] - Model NetworkProfile no longer has parameter peer_vnet_id

                                  @azuresdkci
                                  Copy link
                                  Contributor

                                  Can one of the admins verify this patch?

                                  @xizha162 xizha162 changed the title Dev containerservice microsoft.container service 2020 03 01 Publish Microsoft.ContainerService api-version 2020-03-01 Mar 18, 2020
                                  @xizha162
                                  Copy link
                                  Contributor Author

                                  @NullMDR , please take a look of this PR. We are hoping to merge this ASAP for an marketing announcement. The SDK generation failures do not seem to be related to the change. Known platform issue?

                                  @PhoenixHe-NV PhoenixHe-NV added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 19, 2020
                                  @PhoenixHe-NV PhoenixHe-NV merged commit 08c4662 into master Mar 19, 2020
                                  iscai-msft added a commit that referenced this pull request Mar 20, 2020
                                  …into keyvault_multiapi_readme
                                  
                                  * 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits)
                                    add cli.md for automation (#8411)
                                    adjust assignment (#8782)
                                    Remove Microsoft.Backup.Admin 2016-05-01 API version (#8588)
                                    Updating global setting in PostgreSQL/MySQL readme file (#8777)
                                    update package name and output folder in readme.typescript.md (#8764)
                                    add package-2019-12 python define (#8769)
                                    Fix Parameter Description for validate resource move (#8524)
                                    Edit pass for GA swagger (#8759)
                                    Update proxy.json (#8596)
                                    Model enums that may change in the future as strings (#8760)
                                    Add api-version 2019-11-01 for resources/subscriptions (#8728)
                                    regenerated all-api-versions
                                    PrivateLinkResources for Microsoft.Automation (#8369)
                                    add cli.md for serialconsole (#8401)
                                    add cli.md for mariadb (#8466)
                                    [Computer Vision] Create CV API v3.0-preview (#7402)
                                    Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
                                    Update swagger based on auto-gen process change. (#8766)
                                    add assignment-bot config (#8716)
                                    add tag package-2019-12 to batch (#8751)
                                    ...
                                  00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                                  * Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01
                                  
                                  * Updates readme
                                  
                                  * Updates API version in new specs and examples
                                  
                                  * added sku to managed cluster api (Azure#8426)
                                  
                                  * added sku to managed cluster api
                                  
                                  * move managedcluster sku data model location
                                  
                                  * Generate sdk (Azure#8512)
                                  
                                  * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01
                                  
                                  * Updates readme
                                  
                                  * Updates API version in new specs and examples
                                  
                                  * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)
                                  
                                  * add maxAgentPools and windowsprofile properties
                                  
                                  * fixing the sdk generation error
                                  
                                  * adding load balancer sku property (Azure#5556)
                                  
                                  * Add support VMSS agent nodes with public IP. (Azure#5748)
                                  
                                  * Add identity property in managedCluster definition and add an example (Azure#5709)
                                  
                                  * Add identity property in managedCluster definition and add an example
                                  
                                  * Fix typo
                                  
                                  * readmefor generating sdks
                                  
                                  * remove weird file
                                  
                                  Co-authored-by: Xiaofang Zhang <[email protected]>
                                  Co-authored-by: Jun Sun <[email protected]>
                                  Co-authored-by: Tongyao Si <[email protected]>
                                  
                                  * Add managed AAD section (Azure#8429)
                                  
                                  * add agentpool mode property (Azure#8534)
                                  
                                  * add balance nodegroups flag (Azure#8571)
                                  
                                  Co-authored-by: mslonli <[email protected]>
                                  Co-authored-by: Qingqing <[email protected]>
                                  Co-authored-by: Jun Sun <[email protected]>
                                  Co-authored-by: Tongyao Si <[email protected]>
                                  Co-authored-by: Dong Liu <[email protected]>
                                  Co-authored-by: Marwan Ahmed <[email protected]>
                                  @FumingZhang FumingZhang deleted the dev-containerservice-Microsoft.ContainerService-2020-03-01 branch February 26, 2024 05:33
                                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                                  Labels
                                  None yet
                                  Projects
                                  None yet
                                  Development

                                  Successfully merging this pull request may close these issues.

                                  7 participants