add agentpool mode property #8534

xizha162 · 2020-02-27T01:08:32Z

Latest improvements:

Add agent pool mode property

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-27T01:08:48Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-27T01:10:15Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d7c986 with merge commit 044a95c7314c16581e235dad71ada4db3e2d2d4b. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerService [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

openapi-sdkautomation · 2020-02-27T01:10:16Z

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d7c986 with merge commit 044a95c7314c16581e235dad71ada4db3e2d2d4b. SDK Automation 13.0.17.20191226.1
️✔️sdk/containerservice/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_11_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_02_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_03_01 [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2020-02-27T01:10:17Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d7c986 with merge commit 044a95c7314c16581e235dad71ada4db3e2d2d4b. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-containerservice [Logs] [Preview SDK Changes]

azure-arm-containerservice-11.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 481ms

openapi-sdkautomation · 2020-02-27T01:10:20Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2d7c986 with merge commit 044a95c7314c16581e235dad71ada4db3e2d2d4b. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-containerservice [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-02-27T01:10:21Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 2d7c986 with merge commit 044a95c7314c16581e235dad71ada4db3e2d2d4b. SDK Automation 13.0.17.20191226.1
⚠️containerservice/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-08-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-09-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2018-03-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-04-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-01-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-02-01 [Logs]
```
No file is changed.
```
️✔️containerservice/mgmt/2020-03-01 [Logs] [Preview SDK Changes]
- containerservice.mgmt.2020-03-01.zip
⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs]
```
No file is changed.
```

azuresdkci · 2020-02-27T01:10:30Z

Can one of the admins verify this patch?

azure-pipelines · 2020-02-27T01:10:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-28T19:54:33Z

Azure Pipelines successfully started running 1 pipeline(s).

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-03-01/managedClusters.json

azure-pipelines · 2020-03-03T23:24:26Z

Pull request contains merge conflicts.

….ContainerService-2020-03-01' into dev-containerservice-Microsoft.ContainerService-2020-03-01

azure-pipelines · 2020-03-03T23:28:23Z

Azure Pipelines successfully started running 1 pipeline(s).

xizha162 · 2020-03-05T23:20:30Z

@ryansbenson , @ravbhatnagar please take a look

ravbhatnagar · 2020-03-06T23:37:04Z

Signing off from ARM side as this api-version has not been published yet.

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (#8429) * add agentpool mode property (#8534) * add balance nodegroups flag (#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (Azure#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (Azure#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (Azure#5556) * Add support VMSS agent nodes with public IP. (Azure#5748) * Add identity property in managedCluster definition and add an example (Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (Azure#8429) * add agentpool mode property (Azure#8534) * add balance nodegroups flag (Azure#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

openapi-assignment-bot bot assigned ArcturusZhang Feb 27, 2020

xizha162 requested a review from ravbhatnagar February 27, 2020 01:08

xizha162 force-pushed the dev-containerservice-Microsoft.ContainerService-2020-03-01 branch from ea24d02 to 9f73b82 Compare February 27, 2020 01:10

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 27, 2020

xizha162 force-pushed the dev-containerservice-Microsoft.ContainerService-2020-03-01 branch from 9f73b82 to 2aaa7a6 Compare February 28, 2020 19:54

openapi-sdkautomation bot mentioned this pull request Feb 28, 2020

[AutoPR sdk/containerservice/mgmt-v2020_03_01] add agentpool mode property AzureSDKAutomation/azure-sdk-for-java#1793

Open

ryansbenson reviewed Feb 28, 2020

View reviewed changes

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-03-01/managedClusters.json Show resolved Hide resolved

ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 28, 2020

xizha162 requested a review from ryansbenson March 3, 2020 00:28

add agentpool mode property

8602cbd

xizha162 force-pushed the dev-containerservice-Microsoft.ContainerService-2020-03-01 branch from 2aaa7a6 to 8602cbd Compare March 3, 2020 23:24

Merge remote-tracking branch 'upstream/dev-containerservice-Microsoft…

2d7c986

….ContainerService-2020-03-01' into dev-containerservice-Microsoft.ContainerService-2020-03-01

openapi-sdkautomation bot mentioned this pull request Mar 3, 2020

[AutoPR azure-mgmt-containerservice] add agentpool mode property AzureSDKAutomation/azure-sdk-for-python#532

Open

ravbhatnagar approved these changes Mar 6, 2020

View reviewed changes

ArcturusZhang approved these changes Mar 9, 2020

View reviewed changes

ArcturusZhang merged commit 7318a92 into Azure:dev-containerservice-Microsoft.ContainerService-2020-03-01 Mar 9, 2020

xizha162 mentioned this pull request Mar 18, 2020

Publish Microsoft.ContainerService api-version 2020-03-01 #8756

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add agentpool mode property #8534

add agentpool mode property #8534

xizha162 commented Feb 27, 2020

azure-pipelines bot commented Feb 27, 2020

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

azuresdkci commented Feb 27, 2020

azure-pipelines bot commented Feb 27, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Mar 3, 2020

azure-pipelines bot commented Mar 3, 2020

xizha162 commented Mar 5, 2020

ravbhatnagar commented Mar 6, 2020

add agentpool mode property #8534

add agentpool mode property #8534

Conversation

xizha162 commented Feb 27, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 27, 2020

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading

azure-sdk-for-go

azuresdkci commented Feb 27, 2020

azure-pipelines bot commented Feb 27, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Mar 3, 2020

azure-pipelines bot commented Mar 3, 2020

xizha162 commented Mar 5, 2020

ravbhatnagar commented Mar 6, 2020

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading