Add identity property in managedCluster definition and add an example #5709

norshtein · 2019-04-19T09:22:10Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-04-19T09:22:25Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-19T09:23:02Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4922

AutorestCI · 2019-04-19T09:23:05Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-04-19T09:23:15Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4605

AutorestCI · 2019-04-19T09:23:40Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-04-19T09:24:09Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

norshtein · 2019-04-19T09:49:19Z

Is the CI broken? I run npx autorest --reset && npx autorest --validation --azure-validator --message-format=json specification/containerservice/resource-manager/readme.md locally and no error is reported.

norshtein · 2019-04-19T09:50:43Z

Hi @xizhamsft , could you please help have a review?

...erservice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json

jhendrixMSFT · 2019-04-19T17:51:23Z

Closing then re-open to fix CI.

norshtein · 2019-04-20T06:13:25Z

The CI keeps failed, and the error message seems to be unrelated to this PR. Anything I can do to fix this? @jhendrixMSFT

norshtein · 2019-04-22T05:51:54Z

Close and reopen to fix CI.

jhendrixMSFT · 2019-04-22T21:00:41Z

@norshtein I think your branches are out-of-date. Can you please rebase your PR on top of master and update the target branch as well?

norshtein · 2019-04-23T08:43:48Z

@norshtein I think your branches are out-of-date. Can you please rebase your PR on top of master and update the target branch as well?

CC @xizhamsft . Could you please rebase branch Azure:dev-containerservice-Microsoft.ContainerService-2019-04-01 upon master? I can then rebase this PR upon dev branch.

xizha162 · 2019-04-23T16:36:47Z

/LGTM.
@norshtein, Sun jun is having the same issue. He will ask if they can do the rebase for us. @jhendrixMSFT, could you guys rebase the dev-20190401 branch for us? We don't have write permission to this branch.

jhendrixMSFT · 2019-04-23T21:25:37Z

Target branch has been rebased.

norshtein · 2019-04-24T03:47:09Z

Rebased upon updated target branch.

…Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * node resource group can be read-write (#5762) * Update managed cluster upgrades (#5789) * Update managed cluster upgrades * Fix syntax type error * including 2019-04-01 api version in 2019-04 package * remove the unreferenced MSIManagedClusterCreate_Update.json file * fixing typo per comments

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (#8429) * add agentpool mode property (#8534) * add balance nodegroups flag (#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (Azure#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (Azure#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (Azure#5556) * Add support VMSS agent nodes with public IP. (Azure#5748) * Add identity property in managedCluster definition and add an example (Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (Azure#8429) * add agentpool mode property (Azure#8534) * add balance nodegroups flag (Azure#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (#8426) * added sku to managed cluster api * move managedcluster sku data model location * improve count description * remove useless file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: mslonli <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (Azure#5556) * Add support VMSS agent nodes with public IP. (Azure#5748) * Add identity property in managedCluster definition and add an example (Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo * Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (Azure#8426) * added sku to managed cluster api * move managedcluster sku data model location * improve count description * remove useless file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: mslonli <[email protected]>

azuresdkci assigned jhendrixMSFT Apr 19, 2019

azuresdkci requested a review from jhendrixMSFT April 19, 2019 09:24

nschonni reviewed Apr 19, 2019

View reviewed changes

...erservice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json Show resolved Hide resolved

jhendrixMSFT closed this Apr 19, 2019

jhendrixMSFT reopened this Apr 19, 2019

norshtein closed this Apr 22, 2019

norshtein reopened this Apr 22, 2019

jhendrixMSFT force-pushed the dev-containerservice-Microsoft.ContainerService-2019-04-01 branch from 8741e48 to e095d44 Compare April 23, 2019 21:21

norshtein added 2 commits April 24, 2019 03:38

Add identity property in managedCluster definition and add an example

0c383b6

Fix typo

b2a00bd

norshtein force-pushed the aks-20190401-identity branch from 372d31e to b2a00bd Compare April 24, 2019 03:38

jhendrixMSFT approved these changes Apr 24, 2019

View reviewed changes

jhendrixMSFT merged commit c225658 into Azure:dev-containerservice-Microsoft.ContainerService-2019-04-01 Apr 24, 2019

norshtein deleted the aks-20190401-identity branch April 25, 2019 06:45

xizha162 pushed a commit to xizha162/azure-rest-api-specs that referenced this pull request Apr 30, 2019

Add identity property in managedCluster definition and add an example (…

4529ad1

…Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo

xizha162 mentioned this pull request Apr 30, 2019

Dev containerservice microsoft.container service 2019 04 01 #5797

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add identity property in managedCluster definition and add an example #5709

Add identity property in managedCluster definition and add an example #5709

norshtein commented Apr 19, 2019 •

edited

Loading

azuresdkci commented Apr 19, 2019

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

norshtein commented Apr 19, 2019

norshtein commented Apr 19, 2019

jhendrixMSFT commented Apr 19, 2019

norshtein commented Apr 20, 2019

norshtein commented Apr 22, 2019

jhendrixMSFT commented Apr 22, 2019

norshtein commented Apr 23, 2019

xizha162 commented Apr 23, 2019 •

edited

Loading

jhendrixMSFT commented Apr 23, 2019

norshtein commented Apr 24, 2019

Add identity property in managedCluster definition and add an example #5709

Add identity property in managedCluster definition and add an example #5709

Conversation

norshtein commented Apr 19, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Apr 19, 2019

AutorestCI commented Apr 19, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 19, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 19, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 19, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 19, 2019 • edited Loading

Automation for azure-sdk-for-java

norshtein commented Apr 19, 2019

norshtein commented Apr 19, 2019

jhendrixMSFT commented Apr 19, 2019

norshtein commented Apr 20, 2019

norshtein commented Apr 22, 2019

jhendrixMSFT commented Apr 22, 2019

norshtein commented Apr 23, 2019

xizha162 commented Apr 23, 2019 • edited Loading

jhendrixMSFT commented Apr 23, 2019

norshtein commented Apr 24, 2019

norshtein commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

xizha162 commented Apr 23, 2019 •

edited

Loading