node resource group can be read-write #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
/LGTM |
|
Can one of the admins verify this patch? |
dsgouda
merged commit f4bc40d
into
Azure:dev-containerservice-Microsoft.ContainerService-2019-04-01
xizha162
pushed a commit
to xizha162/azure-rest-api-specs
that referenced
this pull request
Apr 30, 2019
5 tasks
praries880
pushed a commit
that referenced
this pull request
Apr 30, 2019
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * node resource group can be read-write (#5762) * Update managed cluster upgrades (#5789) * Update managed cluster upgrades * Fix syntax type error * including 2019-04-01 api version in 2019-04 package * remove the unreferenced MSIManagedClusterCreate_Update.json file * fixing typo per comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.