Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support VMSS agent nodes with public IP. #5748

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Add support VMSS agent nodes with public IP. #5748

merged 1 commit into from
Apr 24, 2019

Conversation

JunSun17
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from jhendrixMSFT April 23, 2019 23:36
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

veronicagg
veronicagg approved these changes Apr 24, 2019
View reviewed changes
...erservice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json
@@ -1439,6 +1439,10 @@
"type": "string"
},
"description": "(PREVIEW) Availability zones for nodes. Must use VirtualMachineScaleSets AgentPoolType."
},
"enableNodePublicIP": {
"type": "boolean",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may evaluate making this value an enum instead of a Boolean, in case you need to support a range of values in the future.

@veronicagg veronicagg merged commit 9150e84 into Azure:dev-containerservice-Microsoft.ContainerService-2019-04-01 Apr 24, 2019
xizha162 pushed a commit to xizha162/azure-rest-api-specs that referenced this pull request Apr 30, 2019
@JunSun17
Add support VMSS agent nodes with public IP. (Azure#5748)
f69d54c
@xizha162 xizha162 mentioned this pull request Apr 30, 2019
Merged
5 tasks
praries880 pushed a commit that referenced this pull request Apr 30, 2019
@praries880
Dev containerservice microsoft.container service 2019 04 01 (#5797)
0987d5a 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* node resource group can be read-write (#5762)

* Update managed cluster upgrades (#5789)

* Update managed cluster upgrades

* Fix syntax type error

* including 2019-04-01 api version in 2019-04 package

* remove the unreferenced MSIManagedClusterCreate_Update.json file

* fixing typo per comments
@JunSun17 JunSun17 mentioned this pull request May 2, 2019
Closed
weidongxu-microsoft pushed a commit that referenced this pull request Feb 27, 2020
@zqingqing1 @JunSun17 @norshtein
Generate sdk (#8512)
56feec7 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
PhoenixHe-NV pushed a commit that referenced this pull request Mar 19, 2020
@mslonli @zqingqing1
@JunSun17 @norshtein @karataliu @marwanad
Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
08c4662 
* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* Generate sdk (#8512)

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>

* Add managed AAD section (#8429)

* add agentpool mode property (#8534)

* add balance nodegroups flag (#8571)

Co-authored-by: mslonli <[email protected]>
Co-authored-by: Qingqing <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Dong Liu <[email protected]>
Co-authored-by: Marwan Ahmed <[email protected]>
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@mslonli @zqingqing1
@JunSun17 @norshtein @karataliu @marwanad @00Kai0
Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756)
d478ece 
* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* Generate sdk (Azure#8512)

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>

* Add managed AAD section (Azure#8429)

* add agentpool mode property (Azure#8534)

* add balance nodegroups flag (Azure#8571)

Co-authored-by: mslonli <[email protected]>
Co-authored-by: Qingqing <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Dong Liu <[email protected]>
Co-authored-by: Marwan Ahmed <[email protected]>
weidongxu-microsoft pushed a commit that referenced this pull request Sep 27, 2021
@zqingqing1 @JunSun17
@norshtein @mslonli
Improve desire count desc (#16155)
8b68929 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
@zqingqing1 @JunSun17
@norshtein @mslonli
Improve desire count desc (Azure#16155)
0a8fb81 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
@zqingqing1 @JunSun17
@norshtein @mslonli @LeiWang3
Improve desire count desc (Azure#16155)
feeb9e5 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veronicagg veronicagg veronicagg approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JunSun17 @azuresdkci @AutorestCI @veronicagg @jhendrixMSFT