add extra autoscaler flag support #8571

marwanad · 2020-03-02T19:01:20Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-02T19:01:38Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-02T19:02:55Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 301e7ef with merge commit 276b14cfaebc89bd4370f52028e5903f1321609c. SDK Automation 13.0.17.20191226.1
⚠️containerservice/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-08-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-09-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2018-03-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-04-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-01-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-02-01 [Logs]
```
No file is changed.
```
️✔️containerservice/mgmt/2020-03-01 [Logs] [Preview SDK Changes]
- containerservice.mgmt.2020-03-01.zip
⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-02T19:02:55Z

azure-sdk-for-python

❌ failed [Logs] [Expand Details]

❌ Generate from 301e7ef with merge commit 276b14cfaebc89bd4370f52028e5903f1321609c. SDK Automation 13.0.17.20191226.1

[AutoRest] Failure during batch task - {"tag":"pacakge-2020-03-01-only"} -- Error: [Exception] No input files provided.
[AutoRest] 
[AutoRest] Use --help to get help information..
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/z/work/azure-sdk-for-python/sdk /z/work/azure-rest-api-specs/specification/containerservice/resource-manager/readme.md Failure during batch task - {"tag":"pacakge-2020-03-01-only"} -- Error: [Exception] No input files provided.
Use --help to get help information..

, {}

openapi-sdkautomation · 2020-03-02T19:02:57Z

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 301e7ef with merge commit 276b14cfaebc89bd4370f52028e5903f1321609c. SDK Automation 13.0.17.20191226.1
️✔️sdk/containerservice/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_11_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_02_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_03_01 [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2020-03-02T19:02:58Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 301e7ef with merge commit 276b14cfaebc89bd4370f52028e5903f1321609c. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerService [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

openapi-sdkautomation · 2020-03-02T19:02:58Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 301e7ef with merge commit 276b14cfaebc89bd4370f52028e5903f1321609c. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-containerservice [Logs] [Preview SDK Changes]

azure-arm-containerservice-11.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 425ms

xizha162 · 2020-03-02T19:11:40Z

/LGTM

xizha162 · 2020-03-02T19:12:31Z

/LGTM

azuresdkci · 2020-03-02T21:36:46Z

Can one of the admins verify this patch?

markcowl · 2020-03-02T22:58:25Z

/azp run automation - sdk

azure-pipelines · 2020-03-02T22:58:33Z

Azure Pipelines successfully started running 1 pipeline(s).

marwanad · 2020-03-03T22:15:42Z

@markcowl can you help merge this into the dev branch?

azure-pipelines · 2020-03-04T21:06:07Z

Azure Pipelines successfully started running 1 pipeline(s).

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-03-01/managedClusters.json

marwanad · 2020-03-06T23:52:05Z

@markcowl can you ping someone from ARM?

xizha162 · 2020-03-09T22:06:06Z

@ravbhatnagar, could you take a look of this simple change?

ravbhatnagar · 2020-03-11T06:35:59Z

Looks like this change will be made in a new api-version when moving to master, which seems reasonable to me.

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (#5556) * Add support VMSS agent nodes with public IP. (#5748) * Add identity property in managedCluster definition and add an example (#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (#8429) * add agentpool mode property (#8534) * add balance nodegroups flag (#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * added sku to managed cluster api (Azure#8426) * added sku to managed cluster api * move managedcluster sku data model location * Generate sdk (Azure#8512) * Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465) * add maxAgentPools and windowsprofile properties * fixing the sdk generation error * adding load balancer sku property (Azure#5556) * Add support VMSS agent nodes with public IP. (Azure#5748) * Add identity property in managedCluster definition and add an example (Azure#5709) * Add identity property in managedCluster definition and add an example * Fix typo * readmefor generating sdks * remove weird file Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> * Add managed AAD section (Azure#8429) * add agentpool mode property (Azure#8534) * add balance nodegroups flag (Azure#8571) Co-authored-by: mslonli <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Dong Liu <[email protected]> Co-authored-by: Marwan Ahmed <[email protected]>

add balance nodegroups flag

301e7ef

openapi-assignment-bot bot assigned markcowl Mar 2, 2020

xizha162 self-requested a review March 2, 2020 19:11

This was referenced Mar 2, 2020

[AutoPR sdk/containerservice/mgmt-v2019_11_01] add extra autoscaler flag support AzureSDKAutomation/azure-sdk-for-java#1800

Open

[AutoPR sdk/containerservice/mgmt-v2020_01_01] add extra autoscaler flag support AzureSDKAutomation/azure-sdk-for-java#1801

Open

This was referenced Mar 2, 2020

[AutoPR sdk/containerservice/mgmt-v2020_02_01] add extra autoscaler flag support AzureSDKAutomation/azure-sdk-for-java#1802

Open

[AutoPR sdk/containerservice/mgmt-v2020_03_01] add extra autoscaler flag support AzureSDKAutomation/azure-sdk-for-java#1803

Open

markcowl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 4, 2020

markcowl reviewed Mar 4, 2020

View reviewed changes

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-03-01/managedClusters.json Show resolved Hide resolved

xizha162 approved these changes Mar 9, 2020

View reviewed changes

xizha162 requested a review from ravbhatnagar March 9, 2020 20:01

markcowl approved these changes Mar 10, 2020

View reviewed changes

markcowl merged commit a090a07 into Azure:dev-containerservice-Microsoft.ContainerService-2020-03-01 Mar 10, 2020

ravbhatnagar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2020

xizha162 mentioned this pull request Mar 18, 2020

Publish Microsoft.ContainerService api-version 2020-03-01 #8756

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add extra autoscaler flag support #8571

add extra autoscaler flag support #8571

marwanad commented Mar 2, 2020 •

edited by markcowl

Loading

azure-pipelines bot commented Mar 2, 2020

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

xizha162 commented Mar 2, 2020

xizha162 commented Mar 2, 2020

azuresdkci commented Mar 2, 2020

markcowl commented Mar 2, 2020

azure-pipelines bot commented Mar 2, 2020

marwanad commented Mar 3, 2020

azure-pipelines bot commented Mar 4, 2020

marwanad commented Mar 6, 2020

xizha162 commented Mar 9, 2020

ravbhatnagar commented Mar 11, 2020

add extra autoscaler flag support #8571

add extra autoscaler flag support #8571

Conversation

marwanad commented Mar 2, 2020 • edited by markcowl Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 2, 2020

openapi-sdkautomation bot commented Mar 2, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Mar 2, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Mar 2, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Mar 2, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Mar 2, 2020 • edited Loading

azure-sdk-for-js

xizha162 commented Mar 2, 2020

xizha162 commented Mar 2, 2020

azuresdkci commented Mar 2, 2020

markcowl commented Mar 2, 2020

azure-pipelines bot commented Mar 2, 2020

marwanad commented Mar 3, 2020

azure-pipelines bot commented Mar 4, 2020

marwanad commented Mar 6, 2020

xizha162 commented Mar 9, 2020

ravbhatnagar commented Mar 11, 2020

marwanad commented Mar 2, 2020 •

edited by markcowl

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 2, 2020 •

edited

Loading