Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Microsoft.Backup.Admin 2016-05-01 API version #8588

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Remove Microsoft.Backup.Admin 2016-05-01 API version #8588

merged 2 commits into from
Mar 20, 2020

Conversation

daozha
Copy link
Contributor

@daozha daozha commented Mar 4, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 4, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@ArcturusZhang
Copy link
Member

Hi @daozha, is it because this api-version is no longer supported for removing it?

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 5, 2020
@daozha
Copy link
Contributor Author

daozha commented Mar 5, 2020

Hi @daozha, is it because this api-version is no longer supported for removing it?

Hi @ArcturusZhang. Yes, it's no longer supported and from Azure Stack Admin API team's guidance, all the Admin APIs of Azure Stack are still in preview state so we can deprecate and remove them. @bganapa to comment.

@daozha daozha changed the base branch from stackadmin to master March 10, 2020 04:37
@azure-pipelines
Copy link

Pull request contains merge conflicts.

@daozha daozha closed this Mar 10, 2020
@daozha daozha reopened this Mar 10, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

4 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daozha
Copy link
Contributor Author

daozha commented Mar 10, 2020

I've changed target branch to master according to suggestion from @bganapa. @ArcturusZhang, @bganapa, could you help review this PR, and let me know if there's any process we need to go through? Many thanks!

bganapa
bganapa approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@bganapa bganapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deprecated this api version in the past release of AzureStack. Please note that this API surface is for AzureStack Operator. It is not applicable to Azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anthony-c-martin anthony-c-martin removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 20, 2020
@ArcturusZhang ArcturusZhang merged commit 6379030 into Azure:master Mar 20, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 20, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit that referenced this pull request Mar 20, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
4fc6614 
…into keyvault_multiapi_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits)
  add cli.md for automation (#8411)
  adjust assignment (#8782)
  Remove Microsoft.Backup.Admin 2016-05-01 API version (#8588)
  Updating global setting in PostgreSQL/MySQL readme file (#8777)
  update package name and output folder in readme.typescript.md (#8764)
  add package-2019-12 python define (#8769)
  Fix Parameter Description for validate resource move (#8524)
  Edit pass for GA swagger (#8759)
  Update proxy.json (#8596)
  Model enums that may change in the future as strings (#8760)
  Add api-version 2019-11-01 for resources/subscriptions (#8728)
  regenerated all-api-versions
  PrivateLinkResources for Microsoft.Automation (#8369)
  add cli.md for serialconsole (#8401)
  add cli.md for mariadb (#8466)
  [Computer Vision] Create CV API v3.0-preview (#7402)
  Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
  Update swagger based on auto-gen process change. (#8766)
  add assignment-bot config (#8716)
  add tag package-2019-12 to batch (#8751)
  ...
@BryanLa
Copy link
Contributor

BryanLa commented Mar 26, 2020

@daozha et al - whenever specs are deprecated and removed like this, we must also coordinate with the docs team. These specs are used to auto-generate API reference docs (in this case, the Azure Stack Admin API reference docs). When specs are deprecated, a request must be filed to update our CI pipeline to pick up the new/replacement spec. The removal of the stable/2016-05-01/ caused our CI builds to fail for Azure Stack Hub.

I'm the process of working with @troettinger to get all of the Azure Stack specs realigned with our CI config, so this is just a heads up for future changes. If you could pass this along to others that update the Azure Stack Hub swagger specs that would be much appreciated.

Thanks

@bganapa
Copy link
Member

bganapa commented Mar 26, 2020

@BryanLa Thanks and sorry for the hassles. I co-ordinate most of the azurestack admin api efforts. I will be sure to file a request when an api is deprecated(which is a rare event)

@BryanLa
Copy link
Contributor

BryanLa commented Mar 26, 2020

Awesome, thanks @bganapa, and no worries. We I have several updates (including new APIs that our config doesn't know about yet, and new operations for existing APIs), so I hope to get everything updated soon.

@daozha
Copy link
Contributor Author

daozha commented Mar 27, 2020

Thank you @BryanLa and sorry for the break.

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@daozha @00Kai0
Remove Microsoft.Backup.Admin 2016-05-01 API version (Azure#8588)
ff15e88 
* Remove Microsoft.Backup.Admin 2016-05-01 API version

* Change the default tag of Microsoft.Backup.Admin to 2018-09-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bganapa bganapa bganapa approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daozha @azuresdkci @ArcturusZhang @BryanLa @bganapa @anthony-c-martin