Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kafka REST proxy consumer API response in swagger spec #8596

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

jihwang0709
Copy link
Contributor

Update Kafka REST proxy consumer API response in swagger spec

  • add timestamp and timestampType in ConsumeRecord

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Update Kafka REST proxy consumer API response in swagger spec
- add timestamp and timestampType in ConsumeRecord
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2020
@jihwang0709
Copy link
Contributor Author

@yungezz Can you or someone review this PR?

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 17, 2020
@yungezz
Copy link
Member

yungezz commented Mar 19, 2020

hi @jihwang0709 is the service change public on PROD? the PR is ready to merge?

@yungezz
Copy link
Member

yungezz commented Mar 19, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

1 similar comment
@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 19, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@jihwang0709
Copy link
Contributor Author

jihwang0709 commented Mar 19, 2020 via email

@yungezz yungezz merged commit 51654bb into Azure:master Mar 19, 2020
iscai-msft added a commit that referenced this pull request Mar 20, 2020
…into keyvault_multiapi_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits)
  add cli.md for automation (#8411)
  adjust assignment (#8782)
  Remove Microsoft.Backup.Admin 2016-05-01 API version (#8588)
  Updating global setting in PostgreSQL/MySQL readme file (#8777)
  update package name and output folder in readme.typescript.md (#8764)
  add package-2019-12 python define (#8769)
  Fix Parameter Description for validate resource move (#8524)
  Edit pass for GA swagger (#8759)
  Update proxy.json (#8596)
  Model enums that may change in the future as strings (#8760)
  Add api-version 2019-11-01 for resources/subscriptions (#8728)
  regenerated all-api-versions
  PrivateLinkResources for Microsoft.Automation (#8369)
  add cli.md for serialconsole (#8401)
  add cli.md for mariadb (#8466)
  [Computer Vision] Create CV API v3.0-preview (#7402)
  Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
  Update swagger based on auto-gen process change. (#8766)
  add assignment-bot config (#8716)
  add tag package-2019-12 to batch (#8751)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants