add assignment-bot config #8716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
ruowan
added
the
DoNotMerge
akning-ms
reviewed
Mar 16, 2020
| - rule: | ||
| path: "documentation/**" | ||
| reviewers: | ||
| - akning-ms |
There was a problem hiding this comment.
Pls also add @josefree for Document as first reviewer
There was a problem hiding this comment.
So it will rotate to assign for me and josefree? we should always assign to Josefree for documents. or assign both everytime?
There was a problem hiding this comment.
The current design is random pick.
akning-ms
reviewed
Mar 16, 2020
.github/assignment.yml
Outdated
| @@ -0,0 +1,49 @@ | |||
| --- | |||
| - rule: | |||
| path: "specification/**/Microsoft.Network/**" | |||
There was a problem hiding this comment.
Will we have this kind of define in a file like codeowners. e.g reviewers, right?
There was a problem hiding this comment.
I think this format is more flexible
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
josefree
approved these changes
Mar 16, 2020
|
no worry so far. Thanks. |
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
updated rule support paths. 'Paths' means if any pattern in paths matched, the assignment will do assign. |
ruowan
removed
the
DoNotMerge
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akning-ms
approved these changes
Mar 19, 2020
iscai-msft
added a commit
that referenced
this pull request
Mar 20, 2020
…into keyvault_multiapi_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (101 commits) add cli.md for automation (#8411) adjust assignment (#8782) Remove Microsoft.Backup.Admin 2016-05-01 API version (#8588) Updating global setting in PostgreSQL/MySQL readme file (#8777) update package name and output folder in readme.typescript.md (#8764) add package-2019-12 python define (#8769) Fix Parameter Description for validate resource move (#8524) Edit pass for GA swagger (#8759) Update proxy.json (#8596) Model enums that may change in the future as strings (#8760) Add api-version 2019-11-01 for resources/subscriptions (#8728) regenerated all-api-versions PrivateLinkResources for Microsoft.Automation (#8369) add cli.md for serialconsole (#8401) add cli.md for mariadb (#8466) [Computer Vision] Create CV API v3.0-preview (#7402) Publish Microsoft.ContainerService api-version 2020-03-01 (#8756) Update swagger based on auto-gen process change. (#8766) add assignment-bot config (#8716) add tag package-2019-12 to batch (#8751) ...
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* add assignment-bot config * add some customized rule * small fix about data-plane path * add reviewers * add reviewer * add monitor reviewer rule * add resource graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.