Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding note about API being in preview #8088

Closed
wants to merge 293 commits into from
Closed

Adding note about API being in preview #8088

wants to merge 293 commits into from

Conversation

damendo
Copy link
Contributor

@damendo damendo commented Jan 8, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

jlichwa and others added 30 commits November 18, 2019 09:04
* Update swagger spec to add existing log analytics workspace

* remove read only

* changes

* pretty

* ID changed to Id

* run prettier
* add patch to gallery spec

* change descriptions to updated

* updateresource

* Added example and id/type to UpdateResource

* add name

* remove location in examples

* make gallery json pretty
…n operation (#7724)

* Swagger spec update :- Add the missing PATCH for VmssExtension operation

* remove name

* another try by adding back name with "readonly". I guess, a 3rd commit may be required (with readonly for type)

* Added "readOnly": true for type

* add type explicitly in VMSSExtension & Vmss Extension Update.

* Make the publisher & type "readonly" in the VirtualMachineScaleSetExtensionUpdateProperties

* just use VirtualMachineScaleSetExtensionProperties

* Add 201 as well.
* Adding invoices under billing subscriptions

* adding invoiceType

* fixing operationId

* removing next link from get

* removing next link from get
* Add access condition headers

* Add MySQL data source type to preview swagger
…ponse (#7793)

* Billing RP spec changes for listInvoiceSectionsWithCreateSubscriptionPermission API

* Updated the operation id

* Added x-ms-pageable

* Added next link

* Deleted unused file ProductCancelByBillingAccount

* Incorporated review comments

Incorporated review comments

* Added new properties in Invoicing APIs

Added new properties in Invoicing APIs

* Incorporated review comments

Incorporated review comments

* Added invoiceEmailOptIn in the UpdateBillingProfile request

Added invoiceEmailOptIn in the UpdateBillingProfile request

* Update billing.json

* Updating the verbs from Create BillingProfile and InvoiceSection entities

Updating the verbs from Create BillingProfile and InvoiceSection entities

* Corrected the enum valure to match it with actual implementation

Corrected the enum valure to match it with actual implementation

* Updated

* Updating BillingRoleDefinition Permission property to match with actual API response

Updating BillingRoleDefinition Permission property to match with actual API response

* Updated

* Correcting the querystring parameter name as per actual implementation

Correcting the querystring parameter name as per actual implementation

* Updated examples to match it with actual API implementation

Updated examples to match it with actual API implementation
* Fix Microsoft.policyInsights/policyMetadata query parameter

* Fix slim metadata properties
* add ta v3.0-preview.1

* resolve comments

* fix spaces

* update examples

* resolve comments

* update /healthcare and score

* update Bioentity and entityrecord

* temp

* update api changes based on meeting discussions

* update healthcare

* update entity linking

* update naming/description

* update pii

* update required

* udpate required --> still need kv pair for details inside innererror

* update summary and description

* resolve comments -- update opreationid, model-version, errors, etc

* update error

* update error

* remove optional in response, update uppercase of Optional in requests

* update space

* resolve comments

* revole comments

* remove /healthcare

* update score range in description

* update description

* update aka.ms links

* update pii description to use personal information

* resolve comments -- updte detectedLnauges & operationId

* update error enum

* update /readme.md

* update aka.ms links

* update aka.ms links

* update preview read me name & descrition

* update all examples to /examples

* update unkown word to custom-word.txt

* git update folder case name

* update input name to match with example json files

* update 500 to default --> same as previous version .json files

* update MultiLanguageBatchInput

* update examples formatting

* update formatting of .json

* update x-ms-examples descriptions

* test required false for model-version&showStats

* update model-version and showStats

* update formatting

* add x-nullabletrue

* update formmating

* update pii example forammating

* update formaating

* update formatting

* update textanalytics.json format

* testing

* update model-vesrion

* detele required false

* prettier --write

* remove exmpales from TextAnalytics.json

* test keyphrase

* keyphrase

* keyphrase retry

* update keyphrase back

* update ta.json split []
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 8, 2020

azure-sdk-for-go

failed [Logs] [Expand Details]
  • Generate from 3fbb284 with merge commit 17e9ac5ff7b4d6720a02ecd2bd8c5a5cce19612a. SDK Automation 13.0.17.20191226.1
  • ️✔️network/mgmt/2015-06-15 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2016-03-30 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2016-06-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2016-09-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2016-12-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2017-03-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2017-06-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2017-08-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2017-09-01 [Logs]  [Preview SDK Changes]
  • ️✔️network/mgmt/2017-10-01 [Logs]  [Preview SDK Changes]
  • network/mgmt/2017-11-01 [Logs
      SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2017-11-01@8088 --force remote: Invalid username or password.
      fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
      , {}
    • network/mgmt/2018-01-01 [Logs
        SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-01-01@8088 --force remote: Invalid username or password.
        fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
        , {}
      • network/mgmt/2018-02-01 [Logs
          SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-02-01@8088 --force remote: Invalid username or password.
          fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
          , {}
        • network/mgmt/2018-04-01 [Logs
            SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-04-01@8088 --force remote: Invalid username or password.
            fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
            , {}
          • network/mgmt/2018-06-01 [Logs
              SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-06-01@8088 --force remote: Invalid username or password.
              fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
              , {}
            • network/mgmt/2018-07-01 [Logs
                SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-07-01@8088 --force remote: Invalid username or password.
                fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                , {}
              • network/mgmt/2018-08-01 [Logs
                  SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-08-01@8088 --force remote: Invalid username or password.
                  fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                  , {}
                • network/mgmt/2018-10-01 [Logs
                    SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-10-01@8088 --force remote: Invalid username or password.
                    fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                    , {}
                  • network/mgmt/2018-11-01 [Logs
                      SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-11-01@8088 --force remote: Invalid username or password.
                      fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                      , {}
                    • network/mgmt/2018-12-01 [Logs
                        SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2018-12-01@8088 --force remote: Invalid username or password.
                        fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                        , {}
                      • network/mgmt/2019-02-01 [Logs
                          SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-02-01@8088 --force remote: Invalid username or password.
                          fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                          , {}
                        • network/mgmt/2019-04-01 [Logs
                            SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-04-01@8088 --force remote: Invalid username or password.
                            fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                            , {}
                          • network/mgmt/2019-06-01 [Logs
                              SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-06-01@8088 --force remote: Invalid username or password.
                              fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                              , {}
                            • network/mgmt/2019-07-01 [Logs
                                SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-07-01@8088 --force remote: Invalid username or password.
                                fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                                , {}
                              • network/mgmt/2019-08-01 [Logs
                                  SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-08-01@8088 --force remote: Invalid username or password.
                                  fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                                  , {}
                                • network/mgmt/2019-09-01 [Logs
                                    SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/network_mgmt_2019-09-01@8088 --force remote: Invalid username or password.
                                    fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                                    , {}
                                  • preview/network/mgmt/2015-05-01-preview [Logs
                                      SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/preview_network_mgmt_2015-05-01-preview@8088 --force remote: Invalid username or password.
                                      fatal: Authentication failed for 'https://x-access-token:[email protected]/AzureSDKAutomation/azure-sdk-for-go/'
                                      , {}

                                    @openapi-sdkautomation
                                    Copy link

                                    openapi-sdkautomation bot commented Jan 8, 2020

                                    azure-sdk-for-java

                                    ⚠️ warning [Logs] [Expand Details]

                                    @openapi-sdkautomation
                                    Copy link

                                    openapi-sdkautomation bot commented Jan 8, 2020

                                    azure-sdk-for-js

                                    ️✔️ succeeded [Logs] [Expand Details]
                                    • ️✔️ Generate from 3fbb284 with merge commit 17e9ac5ff7b4d6720a02ecd2bd8c5a5cce19612a. SDK Automation 13.0.17.20191226.1
                                    • ️✔️@azure/arm-network [Logs]  [Preview SDK Changes]
                                      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                                      [npmPack] loaded rollup.config.js with warnings
                                      [npmPack] (!) Unused external imports
                                      [npmPack] default imported from external module 'rollup' but never used
                                      [npmPack] 
                                      [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
                                      [npmPack] created ./dist/arm-network.js in 2.3s

                                    @openapi-sdkautomation
                                    Copy link

                                    openapi-sdkautomation bot commented Jan 8, 2020

                                    azure-sdk-for-net

                                    🔄 inProgress [Logs] [Expand Details]
                                    • 🔄 Generate from 3fbb284 with merge commit 17e9ac5ff7b4d6720a02ecd2bd8c5a5cce19612a. SDK Automation 13.0.17.20191226.1

                                    @openapi-sdkautomation
                                    Copy link

                                    openapi-sdkautomation bot commented Jan 8, 2020

                                    azure-sdk-for-python

                                    ️✔️ succeeded [Logs] [Expand Details]
                                    • ️✔️ Generate from 3fbb284 with merge commit 17e9ac5ff7b4d6720a02ecd2bd8c5a5cce19612a. SDK Automation 13.0.17.20191226.1
                                    • ️✔️azure-mgmt-network [Logs]  [Preview SDK Changes]
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-12-01', '2016-09-01'} in label v2016_12_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-01', '2017-03-30'} in label v2017_03_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01', '2017-03-30'} in label v2017_06_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-08-01', '2017-03-30'} in label v2017_08_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-09-01', '2017-03-30'} in label v2017_09_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-10-01'} in label v2017_10_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-11-01', '2017-03-30'} in label v2017_11_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-01-01', '2017-03-30'} in label v2018_01_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01', '2017-03-30'} in label v2018_02_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-04-01', '2017-03-30'} in label v2018_04_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-06-01', '2017-03-30'} in label v2018_06_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-07-01'} in label v2018_07_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-08-01'} in label v2018_08_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2017-03-30'} in label v2018_10_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-11-01', '2017-03-30'} in label v2018_11_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-12-01'} in label v2018_12_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-02-01', '2017-03-30'} in label v2019_02_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-03-30'} in label v2019_04_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2017-03-30'} in label v2019_06_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-07-01', '2019-06-01', '2018-10-01'} in label v2019_07_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2018-10-01', '2019-08-01'} in label v2019_08_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
                                      [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-09-01', '2019-06-01', '2018-10-01'} in label v2019_09_01
                                      [after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
                                      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                      [build_package]   warnings.warn(msg)
                                      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                      [build_package]   warnings.warn(msg)

                                    This was referenced Jan 8, 2020
                                    Copy link

                                    @zikalino zikalino left a comment

                                    Choose a reason for hiding this comment

                                    The reason will be displayed to describe this comment to others. Learn more.

                                    could you change this PR to network-december-release branch?
                                    This is standard practice in case of network spec.

                                    @damendo damendo changed the base branch from master to network-december-release January 9, 2020 05:53
                                    @azure-pipelines
                                    Copy link

                                    Pull request contains merge conflicts.

                                    @damendo damendo closed this Jan 9, 2020
                                    @damendo
                                    Copy link
                                    Contributor Author

                                    damendo commented Jan 9, 2020

                                    Sent new PR here: #8104

                                    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                                    Labels
                                    None yet
                                    Projects
                                    None yet
                                    Development

                                    Successfully merging this pull request may close these issues.