Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CustomerLockbox to add version preview/2018-02-28-preview #7784

Conversation

jiayunge
Copy link
Contributor

@jiayunge jiayunge commented Nov 15, 2019

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8732

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6390

@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 15, 2019
@jiayunge
Copy link
Contributor Author

Here is the PR for the private branch with the same changes: https://github.com/Azure/azure-rest-api-specs-pr/pull/970

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 18, 2019
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical change reviewed in the private repo.

@jiayunge
Copy link
Contributor Author

@myronfanqiu HI, Can you take a look and sign off, not sure if it got blocked because it is missing one more approver

@mmyyrroonn
Copy link
Contributor

@jiayunge The linked PR in the private repo has not been signed off. @lirenhe Hello. Have you signed off for the private PR?

@mmyyrroonn
Copy link
Contributor

@lirenhe Thanks!

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants