Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation #7724

srinath9795 · 2019-11-06T20:12:04Z

Latest improvements:

Added the missing PATCH support for the VMSSExtension operation in the Compute Swagger spec.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-11-06T20:12:45Z

Can one of the admins verify this patch?

AutorestCI · 2019-11-06T20:16:01Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8691

AutorestCI · 2019-11-06T20:18:34Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6375

…t may be required (with readonly for type)

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json

…ensionUpdateProperties

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json

hyonholee · 2019-11-13T01:02:00Z

LGTM

lirenhe · 2019-11-13T06:14:02Z

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json

+            }
+          }
+        },
+        "x-ms-long-running-operation": true


As this is a long running operation, is it better to return 202 instead of 200?

I see that for all the other existing resources (VM, VMSS, AvSet, Image, VMExtension..) as well, only 200 (OK) is specified in the spec.

But from the code, and as CRP treats "patch" & "put" the same way -- added 201 (Created) as well.

@hyonholee to help confirm as well.

ravbhatnagar

Signing off from ARM side barring the one feedback which is to consider adding 202 or 201 (with non-terminal provisioning state) to indicate its long running operation

lirenhe · 2019-11-15T08:30:31Z

@srinath9795, please let me know if the code is ready to merge.

srinath9795 · 2019-11-15T19:05:29Z

@srinath9795, please let me know if the code is ready to merge.

@lirenhe - Yes, the changes for this PR are ready to be merged. Thanks!

…n operation (Azure#7724) * Swagger spec update :- Add the missing PATCH for VmssExtension operation * remove name * another try by adding back name with "readonly". I guess, a 3rd commit may be required (with readonly for type) * Added "readOnly": true for type * add type explicitly in VMSSExtension & Vmss Extension Update. * Make the publisher & type "readonly" in the VirtualMachineScaleSetExtensionUpdateProperties * just use VirtualMachineScaleSetExtensionProperties * Add 201 as well.

CecileRobertMichon · 2020-01-22T01:10:23Z

Hi @lirenhe @ravbhatnagar, this PR introduced a breaking change for AKS. See Azure/aks-engine#2605 for details. TLDR: we were relying on Go struct embedding of Type inside VirtualMachineScaleSetExtensionProperties. After this change, setting extension.Type will not work anymore since a new Type field was added in VirtualMachineScaleSetExtension.
cc @devigned @jackfrancis @AbelHu

devigned · 2020-02-26T22:50:17Z

@jhendrixMSFT, have you seen this issue? It's a pretty gnarly one for Golang in particular.

jhendrixMSFT · 2020-02-27T21:23:53Z

@devigned thanks for bringing this up. It highlights how model flattening is not version-resilient. FYI I've been considering removing this anonymous embedding in track 2, I think this example strengthens the case.

Swagger spec update :- Add the missing PATCH for VmssExtension operation

711abdb

srinath9795 requested a review from hyonholee as a code owner November 6, 2019 20:12

azuresdkci assigned lirenhe Nov 6, 2019

azuresdkci requested a review from lirenhe November 6, 2019 20:13

AutorestCI mentioned this pull request Nov 6, 2019

[AutoPR compute/resource-manager] Swagger spec update :- Add the missing PATCH for VmssExtension operation Azure/azure-sdk-for-python#8463

Closed

srinath9795 changed the title ~~Swagger spec update :- Add the missing PATCH for VmssExtension operation~~ Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation Nov 6, 2019

AutorestCI mentioned this pull request Nov 6, 2019

[AutoPR compute/resource-manager] Swagger spec update :- Add the missing PATCH for VmssExtension operation Azure/azure-sdk-for-go#6279

Closed

srinath9795 added 4 commits November 6, 2019 14:40

remove name

6273e85

another try by adding back name with "readonly". I guess, a 3rd commi…

be55452

…t may be required (with readonly for type)

Added "readOnly": true for type

9057786

add type explicitly in VMSSExtension & Vmss Extension Update.

caa76b5

hyonholee reviewed Nov 7, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json Outdated Show resolved Hide resolved

srinath9795 added 2 commits November 8, 2019 14:49

Make the publisher & type "readonly" in the VirtualMachineScaleSetExt…

06074b1

…ensionUpdateProperties

just use VirtualMachineScaleSetExtensionProperties

bb36785

hyonholee reviewed Nov 8, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json Show resolved Hide resolved

hyonholee reviewed Nov 8, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/compute.json Show resolved Hide resolved

lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 11, 2019

srinath9795 added 2 commits November 11, 2019 11:37

Merge remote-tracking branch 'upstream/master'

3e2e387

Merge branch 'master' into vmssExtensionPatch

e2c5bf3

lirenhe reviewed Nov 13, 2019

View reviewed changes

ravbhatnagar reviewed Nov 14, 2019

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2019

srinath9795 added 3 commits November 14, 2019 14:58

Add 201 as well.

02e260c

Merge remote-tracking branch 'upstream/master'

f1ff170

Merge branch 'master' into vmssExtensionPatch

fd153be

lirenhe approved these changes Nov 15, 2019

View reviewed changes

lirenhe merged commit 0a7f5e5 into Azure:master Nov 18, 2019

CecileRobertMichon mentioned this pull request Jan 28, 2020

refactor: stop using type nesting in billing extensions Azure/aks-engine#2640

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation #7724

Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation #7724

srinath9795 commented Nov 6, 2019

azuresdkci commented Nov 6, 2019

AutorestCI commented Nov 6, 2019 •

edited

Loading

AutorestCI commented Nov 6, 2019 •

edited

Loading

hyonholee commented Nov 13, 2019

lirenhe Nov 13, 2019

srinath9795 Nov 14, 2019 •

edited

Loading

ravbhatnagar left a comment

lirenhe commented Nov 15, 2019

srinath9795 commented Nov 15, 2019

CecileRobertMichon commented Jan 22, 2020

devigned commented Feb 26, 2020

jhendrixMSFT commented Feb 27, 2020

Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation #7724

Compute Swagger spec update :- Add the missing PATCH for VmssExtension operation #7724

Conversation

srinath9795 commented Nov 6, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Nov 6, 2019

AutorestCI commented Nov 6, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Nov 6, 2019 • edited Loading

Automation for azure-sdk-for-go

hyonholee commented Nov 13, 2019

lirenhe Nov 13, 2019

Choose a reason for hiding this comment

srinath9795 Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

ravbhatnagar left a comment

Choose a reason for hiding this comment

lirenhe commented Nov 15, 2019

srinath9795 commented Nov 15, 2019

CecileRobertMichon commented Jan 22, 2020

devigned commented Feb 26, 2020

jhendrixMSFT commented Feb 27, 2020

AutorestCI commented Nov 6, 2019 •

edited

Loading

AutorestCI commented Nov 6, 2019 •

edited

Loading

srinath9795 Nov 14, 2019 •

edited

Loading