Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Certificate Type description #7762

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Update Certificate Type description #7762

merged 7 commits into from
Nov 18, 2019

Conversation

jlichwa
Copy link
Contributor

@jlichwa jlichwa commented Nov 12, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@jlichwa jlichwa requested a review from schaabs as a code owner November 12, 2019 01:12
@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6368

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaohaizh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ruowan
Copy link
Member

ruowan commented Nov 13, 2019

It's model validation error. @raych1 Could you please take a look at this error.

@raych1
Copy link
Member

raych1 commented Nov 13, 2019

@yaohaizh , those model validation errors are there before and are not caused by this PR change.
@jlichwa, I would suggest to fix those errors in separate PR otherwise these issues will appear in every future PR.

@yaohaizh
Copy link
Contributor

yaohaizh commented Nov 13, 2019

@jlichwa Please fix the model validation errors in another PR since the previous swagger spec doesn't have the correct value.

@jlichwa
Copy link
Contributor Author

jlichwa commented Nov 13, 2019

@jlichwa Please fix the model validation errors in another PR since the previous swagger spec doesn't have the correct value.

Ok I will reach out to engineering team. I was updating this file only for documentation purposes - so the docs generated from it are clearly describing paramaters.

@yungezz yungezz merged commit 5456ce5 into Azure:master Nov 18, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants