Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating request and response properties to match with actual API response #7793

Merged
merged 23 commits into from
Nov 20, 2019
Merged

Updating request and response properties to match with actual API response #7793

merged 23 commits into from
Nov 20, 2019

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Nov 18, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Incorporated review comments
Added new properties in Invoicing APIs
Incorporated review comments
Added invoiceEmailOptIn in the UpdateBillingProfile request
…ties

Updating the verbs from Create BillingProfile and InvoiceSection entities
Corrected the enum valure to match it with actual implementation
…al API response

Updating BillingRoleDefinition Permission property to match with actual API response
@AutorestCI
Copy link

AutorestCI commented Nov 18, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8699

@AutorestCI
Copy link

AutorestCI commented Nov 18, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2019
Correcting the querystring parameter name as per actual implementation
@asarkar84 asarkar84 changed the title Updating BillingRoleDefinition Permission property to match with actual API response Updating request and response properties to match with actual API response Nov 19, 2019
Updated examples to match it with actual API implementation
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a stable api version, this would be considered a breaking change. Please communicate this with preview partners.

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 19, 2019
@ChenTanyi ChenTanyi merged commit c96c1a0 into Azure:master Nov 20, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
…ponse (Azure#7793)

* Billing RP spec changes for listInvoiceSectionsWithCreateSubscriptionPermission API

* Updated the operation id

* Added x-ms-pageable

* Added next link

* Deleted unused file ProductCancelByBillingAccount

* Incorporated review comments

Incorporated review comments

* Added new properties in Invoicing APIs

Added new properties in Invoicing APIs

* Incorporated review comments

Incorporated review comments

* Added invoiceEmailOptIn in the UpdateBillingProfile request

Added invoiceEmailOptIn in the UpdateBillingProfile request

* Update billing.json

* Updating the verbs from Create BillingProfile and InvoiceSection entities

Updating the verbs from Create BillingProfile and InvoiceSection entities

* Corrected the enum valure to match it with actual implementation

Corrected the enum valure to match it with actual implementation

* Updated

* Updating BillingRoleDefinition Permission property to match with actual API response

Updating BillingRoleDefinition Permission property to match with actual API response

* Updated

* Correcting the querystring parameter name as per actual implementation

Correcting the querystring parameter name as per actual implementation

* Updated examples to match it with actual API implementation

Updated examples to match it with actual API implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants