Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Microsoft.policyInsights/policyMetadata query parameter #7805

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

eladperets
Copy link
Contributor

@eladperets eladperets commented Nov 19, 2019

Latest improvements:

Fixed missing $top query parameter. Removed properties from the collection GET response.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8724

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6389

@pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 19, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@eladperets eladperets closed this Nov 19, 2019
@eladperets eladperets reopened this Nov 19, 2019
@ChenTanyi ChenTanyi merged commit f671434 into Azure:master Nov 20, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
* Fix Microsoft.policyInsights/policyMetadata query parameter

* Fix slim metadata properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants