Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Billing Adding billingSubscriptions/invoices #7769

Merged
merged 6 commits into from
Nov 18, 2019
Merged

Microsoft.Billing Adding billingSubscriptions/invoices #7769

merged 6 commits into from
Nov 18, 2019

Conversation

muazmian
Copy link
Contributor

@muazmian muazmian commented Nov 12, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@muazmian muazmian requested a review from wilcobmsft as a code owner November 12, 2019 23:20
@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8613

@AutorestCI
Copy link

AutorestCI commented Nov 12, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@wilcobmsft wilcobmsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 14, 2019
@lirenhe
Copy link
Member

lirenhe commented Nov 14, 2019

@muazmian, could you run prettier to fix the code style problem?

Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@@ -5887,6 +5991,19 @@
"format": "date-time",
"readOnly": true
},
"invoiceType" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically if this was a stable api version, it would be a breaking change. Please communicate this accordingly.

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 18, 2019
@lirenhe lirenhe merged commit 558069e into Azure:master Nov 18, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
* Adding invoices under billing subscriptions

* adding invoiceType

* fixing operationId

* removing next link from get

* removing next link from get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants