Protect: Dismissible Network Activation Warning

[mdawaffe]

Changes proposed in this Pull Request:

The warning about Jetpack Protect's network activation warning is not dismissible.

It is also not pretty :)

Both have been problems since #3841.

• Use markup compatible with Core's notices.
• Hook some JS into Core's notice dismissal to handle changing saved state.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No: bug fix.

Testing instructions:

1. Create a multisite.
2. Do not network activate the Jetpack plugin.
3. Activate the Jetpack plugin on a single site.
4. Connect Jetpack on that site.
5. Go to that site's wp-admin/ dashboard.

Prior to this patch: See an ugly message and note that it cannot be dismissed.

After this patch: See a prettier, dismissible warning. To test repeated dismissals, you can do:
wp site option delete jetpack_dismissed_protect_multisite_banner
to reset the dismissal to the default state.

UI Changes

Before:

After:

Copy Changes

I think it's the case that we're not using "Jetpack Protect" for this feature anymore. Is that true?

Before:

Protect cannot keep your site secure.

Thanks for activating Protect! To start protecting your site, please network activate Jetpack on your Multisite installation and activate Protect on your primary site. Due to the way logins are handled on WordPress Multisite, Jetpack must be network-enabled in order for Protect to work properly. Learn More

View Network Admin

After:

Jetpack Brute Force Attack Prevention cannot keep your site secure

Thanks for activating Jetpack's brute force attack prevention feature! To start protecting your whole WordPress Multisite Network, please network activate the Jetpack plugin. Due to the way logins are handled on WordPress Multisite Networks, Jetpack must be network activated in order for the brute force attack prevention feature to work properly.

[View Network Admin] [Learn More]

Proposed changelog entry for your changes:

• Fix a Jetpack Brute Force Attack Prevention notice on WordPress Multisites.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against d10cc53

[jeherve]

This works well for me. 👍

[dereksmart]

Very nice improvement