WordAds Block: AMP Support #12733

jeffersonrabb · 2019-06-18T17:58:10Z

Changes proposed in this Pull Request:

This PR brings AMP compatibility to the Jetpack Ads block.

A couple of gotchas:

The Additional ad placements->Top of each page option will lead to AMP incompatibility in TwentySeventeen, TwentyFifteen, and TwentyFourteen. This is due to https://github.com/Automattic/jetpack/blob/master/modules/wordads/wordads.php#L400-L402. I plan to address this in a separate PR since this doesn't directly relate to the block.
AMP ads will be blocked if Settings->Reading->Search Engine Visibility->Discourage search engines from indexing this site is checked.
Make sure you have no ad blockers enabled (I fell for this one more than once :-) )

Testing instructions:

Spin up a Jurassic Ninja instance with this link: ~~https://jurassic.ninja/create/?branch=add/amp-ads-support~~ http://jurassic.ninja/create/?jetpack-beta&branch=add/amp-ads-support
Connect Jetpack, and upgrade to Premium.
Navigate to /wp-admin/admin.php?page=jetpack#/traffic.
Enable Ads. Switch off Additional ad placements->Top of each page (see note above)
Install and activate the AMP plugin: https://wordpress.org/plugins/amp/
Go to AMP settings and switch to Transitional mode.
Create a post, add Ads block, publish the post.
View published post, in both AMP and non-AMP environments. You should see roughly identical output in both.

Proposed changelog entry for your changes:

AMP compatibility for the Jetpack Ads block.

jetpackbot · 2019-06-18T18:00:19Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 2349a05

dbspringer · 2019-06-18T18:04:32Z

One question I have is: there's a few different AMP implementations available for self-hosted sites, does this one target one in particular, or is it more of a generic solution? We may need to consider supporting a handful of the most popular AMP options.

Though I suppose if a different version of AMP is used our is_amp checks will just return false.

jeffersonrabb · 2019-06-18T18:08:46Z

One question I have is: there's a few different AMP implementations available for self-hosted sites, does this one target one in particular, or is it more of a generic solution? We may need to consider supporting a handful of the most popular AMP options.

By "different AMP implementations" do you mean plugins other than the official one: https://wordpress.org/plugins/amp/ ?

dbspringer

Generally looks good, just a question about which AMP implementations we need to support.

modules/wordads/wordads.php

dbspringer · 2019-06-18T18:09:29Z

modules/wordads/wordads.php

@@ -496,6 +514,17 @@ function get_ad_snippet( $section_id, $height, $width, $location = '', $css = ''
 		if ( ! empty( self::$ad_location_ids[ $location ] ) ) {
 			$loc_id = self::$ad_location_ids[ $location ];
 		}
+		if ( class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request() ) {


We may want to consider extracting this into a separate is_amp function to include support for various versions of AMP solutions self-hosted sites might use.

Unless we're firm on only supporting the Jetpack_AMP_Support version, then nevermind :)

As noted in #12733 (comment), let's see what Jetpack folks think?

dbspringer · 2019-06-18T18:16:59Z

Looks like there's at least three different implementations w/ > 10,000 active installs. Maybe if there's an "official" one we can just say that's the one we support.

jeffersonrabb · 2019-06-18T18:25:32Z

Looks like there's at least three different implementations w/ > 10,000 active installs. Maybe if there's an "official" one we can just say that's the one we support.

Yeah, interesting point. This check https://github.com/Automattic/jetpack/blob/master/3rd-party/class.jetpack-amp-support.php#L56-L72 is already used pretty widely throughout Jetpack, but I'll leave it to @Automattic/jetpack-crew to comment on whether we might need to broaden support?

westonruter · 2019-06-18T19:01:00Z

Maybe if there's an "official" one we can just say that's the one we support.

There is an official one, and it is the one being directly supported: https://wordpress.org/plugins/amp/

This is what runs on WordPress.com

Other plugins that want to shim support can do so via the filter exposed in Jetpack_AMP_Support.

westonruter · 2019-06-18T19:01:49Z

Also, the AMP for WP plugin includes an old version of the official AMP plugin, so the same conditionals should work.

dbspringer · 2019-06-18T19:01:57Z

Regardless of whether or not we add support for other versions, I think it makes sense to extract the check into a separate function -- which I did :)

westonruter · 2019-06-18T19:03:52Z

modules/wordads/wordads.php

+			<amp-ad width="$width" height="$height"
+			    type="pubmine"
+			    data-siteid="$site_id"
+			    data-section="$amp_section_id">


These should use esc_attr() no?

Thanks, added.

westonruter · 2019-06-18T19:05:44Z

modules/wordads/wordads.php

+HTML;
+		}
+
+		$ad_number = count( $this->ads ) . '-' . uniqid();


Using uniqid breaks the AMP plugin's post-processor cache. Better to use https://developer.wordpress.org/reference/functions/wp_unique_id/ or a polyfill.

Though I suppose this won't run in AMP anyway since it's after the return?

Though I suppose this won't run in AMP anyway since it's after the return?

That's correct.

dbspringer

Okay, I think this update is now a solid enough first release while the other updates noted get worked on.

jeffersonrabb · 2019-06-19T17:12:37Z

The Additional ad placements->Top of each page option will lead to AMP incompatibility in TwentySeventeen, TwentyFifteen, and TwentyFourteen. This is due to https://github.com/Automattic/jetpack/blob/master/modules/wordads/wordads.php#L400-L402. I

This is resolved in 877f0cd. For AMP requests, the unit will be inserted above the content, below the title. After discussing with @dbspringer we decided there wasn't any way to match the non-AMP positioning without using Javascript. This isn't precisely the same as the non-AMP placement, but is similar in spirit.

jeherve

I'm getting the following notice when trying to view a post in an AMP view:

PHP Notice:  is_amp_endpoint was called <strong>incorrectly</strong>. is_amp_endpoint() was called before the parse_query hook was called. Please see <a href="https://codex.wordpress.org/Debugging_in_WordPress">Debugging in WordPress</a> for more information. (This message was added in version 0.4.2.) in /var/www/html/wp-includes/functions.php on line 4773
[20-Jun-2019 13:49:11 UTC] PHP Stack trace:
[20-Jun-2019 13:49:11 UTC] PHP   1. {main}() /var/www/html/index.php:0
[20-Jun-2019 13:49:11 UTC] PHP   2. require() /var/www/html/index.php:17
[20-Jun-2019 13:49:11 UTC] PHP   3. require_once() /var/www/html/wp-blog-header.php:13
[20-Jun-2019 13:49:11 UTC] PHP   4. require_once() /var/www/html/wp-load.php:37
[20-Jun-2019 13:49:11 UTC] PHP   5. require_once() /var/www/html/wp-config.php:85
[20-Jun-2019 13:49:11 UTC] PHP   6. do_action() /var/www/html/wp-settings.php:525
[20-Jun-2019 13:49:11 UTC] PHP   7. WP_Hook->do_action() /var/www/html/wp-includes/plugin.php:465
[20-Jun-2019 13:49:11 UTC] PHP   8. WP_Hook->apply_filters() /var/www/html/wp-includes/class-wp-hook.php:310
[20-Jun-2019 13:49:11 UTC] PHP   9. WordAds->init() /var/www/html/wp-includes/class-wp-hook.php:286
[20-Jun-2019 13:49:11 UTC] PHP  10. WordAds->insert_adcode() /var/www/html/wp-content/plugins/jetpack/modules/wordads/wordads.php:156
[20-Jun-2019 13:49:11 UTC] PHP  11. WordAds::is_amp() /var/www/html/wp-content/plugins/jetpack/modules/wordads/wordads.php:235
[20-Jun-2019 13:49:11 UTC] PHP  12. Jetpack_AMP_Support::is_amp_request() /var/www/html/wp-content/plugins/jetpack/modules/wordads/wordads.php:78
[20-Jun-2019 13:49:11 UTC] PHP  13. is_amp_endpoint() /var/www/html/wp-content/plugins/jetpack/3rd-party/class.jetpack-amp-support.php:62
[20-Jun-2019 13:49:11 UTC] PHP  14. _doing_it_wrong() /var/www/html/wp-content/plugins/amp/includes/amp-helper-functions.php:275
[20-Jun-2019 13:49:11 UTC] PHP  15. trigger_error() /var/www/html/wp-includes/functions.php:4773

Previous art on that topic: #11195

jeffersonrabb · 2019-06-20T15:58:11Z

@dbspringer any issue with skipping insert_head_iponweb() and insert_head_meta() in AMP environments? 0e1a7ed

dbspringer · 2019-06-20T16:00:15Z

Yeah, totally fine 👍(I'm pretty sure AMP would just strip them out anyway)

modules/wordads/wordads.php

jeherve · 2019-06-20T20:46:11Z

Rebasing to fix tests.

jeffersonrabb · 2019-07-26T11:19:01Z

Rebased.

jeherve

I am now getting the following errors when editing a post that contains Ad blocks:

Notice:  Trying to get property 'blog_id' of non-object in wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php on line 93
Notice:  Trying to get property 'cloudflare' of non-object in wp-content/plugins/jetpack-dev/modules/wordads/wordads.php on line 566
Notice:  Trying to get property 'blog_id' of non-object in wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php on line 93
Notice:  Trying to get property 'cloudflare' of non-object in wp-content/plugins/jetpack-dev/modules/wordads/wordads.php on line 566
Notice:  Trying to get property 'blog_id' of non-object in wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php on line 93
Notice:  Trying to get property 'cloudflare' of non-object in wp-content/plugins/jetpack-dev/modules/wordads/wordads.php on line 566
Warning:  Cannot modify header information - headers already sent by (output started at wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php:93) in wp-includes/option.php on line 947
Warning:  Cannot modify header information - headers already sent by (output started at wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php:93) in wp-includes/option.php on line 948

$wordads->params appears to be null.

This can even cause a Fatal error if you hide one of the ads on mobile using the block option:

Fatal error: Uncaught Error: Call to a member function is_mobile() on null
in wp-content/plugins/jetpack-dev/extensions/blocks/wordads/wordads.php on line 83

This does not appear on Jetpack Stable.

jeffersonrabb · 2019-07-26T17:57:25Z

Hmmm, this is tricky. Looks like the new Block fatals came about because of the change in the init action from init to wp in 65ae218. @westonruter, given this change was made to address the AMP _doing_it_wrong error (#12733 (comment)) do you have any suggestions for how to reconcile these two situations?

westonruter · 2019-07-27T03:37:14Z

Why do the fatals occur due to moving the logic from init to wp, an action that happens later in WordPress's execution?

…n API requests.

jeffersonrabb · 2019-08-05T23:52:02Z

After discussing with @westonruter 2349a05 should resolve the issue by using different initialization hooks for API and non-API requests.

jeherve · 2019-08-06T17:05:54Z

For the most part it seems to work well now. I do, however, run into Fatals from AMP now:

[06-Aug-2019 17:04:24 UTC] PHP Fatal error:  Unknown: Cannot use output buffering in output buffering display handlers in Unknown on line 0
[06-Aug-2019 17:04:24 UTC] PHP Stack trace:
[06-Aug-2019 17:04:24 UTC] PHP   1. shutdown_action_hook() /var/www/html/wp-includes/load.php:0
[06-Aug-2019 17:04:24 UTC] PHP   2. do_action() /var/www/html/wp-includes/load.php:954
[06-Aug-2019 17:04:24 UTC] PHP   3. WP_Hook->do_action() /var/www/html/wp-includes/plugin.php:465
[06-Aug-2019 17:04:24 UTC] PHP   4. WP_Hook->apply_filters() /var/www/html/wp-includes/class-wp-hook.php:310
[06-Aug-2019 17:04:24 UTC] PHP   5. wp_ob_end_flush_all() /var/www/html/wp-includes/class-wp-hook.php:286
[06-Aug-2019 17:04:24 UTC] PHP   6. ob_end_flush() /var/www/html/wp-includes/functions.php:4339
[06-Aug-2019 17:04:24 UTC] PHP   7. AMP_Theme_Support::finish_output_buffering() /var/www/html/wp-includes/functions.php:4339
[06-Aug-2019 17:04:25 UTC] PHP   8. AMP_Theme_Support::prepare_response() /var/www/html/wp-content/plugins/amp/includes/class-amp-theme-support.php:1766
[06-Aug-2019 17:04:25 UTC] PHP   9. AMP_Content_Sanitizer::sanitize_document() /var/www/html/wp-content/plugins/amp/includes/class-amp-theme-support.php:2093
[06-Aug-2019 17:04:25 UTC] PHP  10. AMP_Style_Sanitizer->sanitize() /var/www/html/wp-content/plugins/amp/includes/templates/class-amp-content-sanitizer.php:117
[06-Aug-2019 17:04:25 UTC] PHP  11. AMP_Style_Sanitizer->process_link_element() /var/www/html/wp-content/plugins/amp/includes/sanitizers/class-amp-style-sanitizer.php:731
[06-Aug-2019 17:04:25 UTC] PHP  12. AMP_Style_Sanitizer->process_stylesheet() /var/www/html/wp-content/plugins/amp/includes/sanitizers/class-amp-style-sanitizer.php:1186
[06-Aug-2019 17:04:25 UTC] PHP  13. AMP_Style_Sanitizer->prepare_stylesheet() /var/www/html/wp-content/plugins/amp/includes/sanitizers/class-amp-style-sanitizer.php:1315
[06-Aug-2019 17:04:25 UTC] PHP  14. AMP_Style_Sanitizer->parse_stylesheet() /var/www/html/wp-content/plugins/amp/includes/sanitizers/class-amp-style-sanitizer.php:1565
[06-Aug-2019 17:04:25 UTC] PHP  15. Sabberworm\CSS\Parser->parse() /var/www/html/wp-content/plugins/amp/includes/sanitizers/class-amp-style-sanitizer.php:1480
[06-Aug-2019 17:04:25 UTC] PHP  16. Sabberworm\CSS\CSSList\Document::parse() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parser.php:38
[06-Aug-2019 17:04:25 UTC] PHP  17. Sabberworm\CSS\CSSList\CSSList::parseList() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/Document.php:21
[06-Aug-2019 17:04:25 UTC] PHP  18. Sabberworm\CSS\CSSList\CSSList::parseListItem() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/CSSList.php:49
[06-Aug-2019 17:04:25 UTC] PHP  19. Sabberworm\CSS\RuleSet\DeclarationBlock::parse() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/CSSList.php:98
[06-Aug-2019 17:04:25 UTC] PHP  20. Sabberworm\CSS\Parsing\ParserState->consumeUntil() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php:31
[06-Aug-2019 17:04:25 UTC] PHP  21. Sabberworm\CSS\Parsing\ParserState->consumeComment() /var/www/html/wp-content/plugins/amp/vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/ParserState.php:225

@westonruter Does this ring a bell?

westonruter · 2019-08-06T18:02:14Z

@jeherve Humm. Are you getting any other error in the log?

What is the MEMORY_LIMIT in your install? I've been able to reproduce that problem if I lower my MEMORY_LIMIT: ampproject/amp-wp#1915 (comment)

When testing with @jeffersonrabb we didn't see this issue.

jeffersonrabb · 2019-08-06T18:04:28Z

What is the MEMORY_LIMIT in your install?

If this is a memory issue, wouldn't we expect to see the same on Jetpack stable?

jeherve · 2019-08-07T18:54:12Z

What is the MEMORY_LIMIT in your install?

64M, but I see that I have the same problem with master, so whatever is happening on my site is not caused by this branch.

I'll let someone else jump in and test this instead of me.

jeherve

This tests well for me today. Merging.

* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335

jeffersonrabb requested a review from a team June 18, 2019 17:58

jeffersonrabb added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 18, 2019

jeffersonrabb self-assigned this Jun 18, 2019

jeffersonrabb added AMP [Feature] WordAds labels Jun 18, 2019

jeffersonrabb requested review from rclations, dbspringer and cphilleo June 18, 2019 17:59

dbspringer reviewed Jun 18, 2019

View reviewed changes

westonruter reviewed Jun 18, 2019

View reviewed changes

dbspringer previously approved these changes Jun 18, 2019

View reviewed changes

jeffersonrabb dismissed dbspringer’s stale review via 877f0cd June 19, 2019 17:07

jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jun 20, 2019

jeherve added this to the 7.5 milestone Jun 20, 2019

jeherve requested changes Jun 20, 2019

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 20, 2019

westonruter reviewed Jun 20, 2019

View reviewed changes

modules/wordads/wordads.php Show resolved Hide resolved

jeffersonrabb force-pushed the add/amp-ads-support branch from 39a9c8c to 65ae218 Compare July 26, 2019 11:17

jeffersonrabb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 26, 2019

jeherve requested changes Jul 26, 2019

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 26, 2019

Initialize WordAds at rest_api_init action, for error-free behavior i…

2349a05

…n API requests.

jeffersonrabb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 5, 2019

jeherve added this to the 7.7 milestone Aug 7, 2019

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 26, 2019

jeherve approved these changes Aug 26, 2019

View reviewed changes

jeherve merged commit e12fef4 into master Aug 26, 2019

jeherve deleted the add/amp-ads-support branch August 26, 2019 13:42

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 26, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Aug 26, 2019

jeherve added a commit that referenced this pull request Aug 26, 2019

Changelog: add #12733

5bcb761

jeherve mentioned this pull request Mar 22, 2023

[WIP]: Add Sponsored Post feature to WordAds #29597

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WordAds Block: AMP Support #12733

WordAds Block: AMP Support #12733

jeffersonrabb commented Jun 18, 2019 •

edited

Loading

jetpackbot commented Jun 18, 2019 •

edited

Loading

dbspringer commented Jun 18, 2019

jeffersonrabb commented Jun 18, 2019

dbspringer left a comment

dbspringer Jun 18, 2019

jeffersonrabb Jun 18, 2019

dbspringer commented Jun 18, 2019

jeffersonrabb commented Jun 18, 2019

westonruter commented Jun 18, 2019

westonruter commented Jun 18, 2019

dbspringer commented Jun 18, 2019 •

edited

Loading

westonruter Jun 18, 2019

dbspringer Jun 18, 2019

westonruter Jun 18, 2019

westonruter Jun 18, 2019

dbspringer Jun 18, 2019 •

edited

Loading

dbspringer left a comment

jeffersonrabb commented Jun 19, 2019

jeherve left a comment

jeffersonrabb commented Jun 20, 2019

dbspringer commented Jun 20, 2019 •

edited

Loading

jeherve commented Jun 20, 2019

jeffersonrabb commented Jul 26, 2019

jeherve left a comment

jeffersonrabb commented Jul 26, 2019

westonruter commented Jul 27, 2019

jeffersonrabb commented Aug 5, 2019

jeherve commented Aug 6, 2019

westonruter commented Aug 6, 2019

jeffersonrabb commented Aug 6, 2019

jeherve commented Aug 7, 2019

jeherve left a comment

WordAds Block: AMP Support #12733

WordAds Block: AMP Support #12733

Conversation

jeffersonrabb commented Jun 18, 2019 • edited Loading

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

jetpackbot commented Jun 18, 2019 • edited Loading

dbspringer commented Jun 18, 2019

jeffersonrabb commented Jun 18, 2019

dbspringer left a comment

Choose a reason for hiding this comment

dbspringer Jun 18, 2019

Choose a reason for hiding this comment

jeffersonrabb Jun 18, 2019

Choose a reason for hiding this comment

dbspringer commented Jun 18, 2019

jeffersonrabb commented Jun 18, 2019

westonruter commented Jun 18, 2019

westonruter commented Jun 18, 2019

dbspringer commented Jun 18, 2019 • edited Loading

westonruter Jun 18, 2019

Choose a reason for hiding this comment

dbspringer Jun 18, 2019

Choose a reason for hiding this comment

westonruter Jun 18, 2019

Choose a reason for hiding this comment

westonruter Jun 18, 2019

Choose a reason for hiding this comment

dbspringer Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

dbspringer left a comment

Choose a reason for hiding this comment

jeffersonrabb commented Jun 19, 2019

jeherve left a comment

Choose a reason for hiding this comment

jeffersonrabb commented Jun 20, 2019

dbspringer commented Jun 20, 2019 • edited Loading

jeherve commented Jun 20, 2019

jeffersonrabb commented Jul 26, 2019

jeherve left a comment

Choose a reason for hiding this comment

jeffersonrabb commented Jul 26, 2019

westonruter commented Jul 27, 2019

jeffersonrabb commented Aug 5, 2019

jeherve commented Aug 6, 2019

westonruter commented Aug 6, 2019

jeffersonrabb commented Aug 6, 2019

jeherve commented Aug 7, 2019

jeherve left a comment

Choose a reason for hiding this comment

jeffersonrabb commented Jun 18, 2019 •

edited

Loading

jetpackbot commented Jun 18, 2019 •

edited

Loading

dbspringer commented Jun 18, 2019 •

edited

Loading

dbspringer Jun 18, 2019 •

edited

Loading

dbspringer commented Jun 20, 2019 •

edited

Loading