Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jetpack Authors Widget Filter #13167

Merged
merged 2 commits into from Aug 14, 2019
Merged

Add Jetpack Authors Widget Filter #13167

merged 2 commits into from Aug 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2019

In #13141, @jeherve suggested adding a new filter to update all parameters of the get_user function call in the Jetpack Authors widget.

Changes proposed in this Pull Request:

Addition of the suggested filter.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This adds functionality to an existing feature.

Testing instructions:

  • Add a test plugin containing a function hooked onto the new filter.
  • Add or remove parameters in the test function
  • Ensure changes are applied as parameters are changed via the filter.

Proposed changelog entry for your changes:

  • Jetpack Authors Widget: add a filter for all parameters passed to get_user

@ghost ghost self-requested a review August 1, 2019 13:53
@jetpackbot
Copy link

jetpackbot commented Aug 1, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against c3e81ae

@jeherve jeherve added [Pri] Low [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets labels Aug 1, 2019
jeherve
jeherve requested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Here are a few minor comments and nitpicks to try to keep things as simple as possible.

modules/widgets/authors.php Outdated Show resolved Hide resolved
modules/widgets/authors.php Show resolved Hide resolved
modules/widgets/authors.php Outdated Show resolved Hide resolved
modules/widgets/authors.php Outdated Show resolved Hide resolved
modules/widgets/authors.php Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 1, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 1, 2019
Added jetpack_widget_authors_exclude to the deprecated hooks list a…
c3e81ae 
…nd added the deprecated notice to the docblock. Other minor changes to make the parsers happy. Feedback thanks to @jeherve.
@ghost
Copy link
Author

ghost commented Aug 1, 2019

Thanks for the feedback, @jeherve!

@lezama
Copy link
Contributor

lezama commented Aug 1, 2019

My first team lead ❤️ , how is it going Tim?! definitely not a First-time contributor :)

@ghost
Copy link
Author

ghost commented Aug 1, 2019

My first team lead ❤️ , how is it going Tim?! definitely not a First-time contributor :)

It's good! How are you?

Certainly not a first-time contributor, but starting somewhere small to get familiar with the changes!

@lezama
Copy link
Contributor

lezama commented Aug 1, 2019

It's good! How are you?

doing good! happy to see you around!

jeherve
jeherve approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 2, 2019
@mdawaffe mdawaffe merged commit 39c124f into Automattic:master Aug 14, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 14, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
@jeherve
Changelog: add #13167
9b75466
jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Extra Sidebar Widgets [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.
5 participants
@jetpackbot @lezama @jeherve @mdawaffe @matticbot