Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTP references to HTTPS #13306

Merged
merged 7 commits into from
Aug 23, 2019
Merged

Update HTTP references to HTTPS #13306

merged 7 commits into from
Aug 23, 2019

Conversation

mdawaffe
Copy link
Member

@mdawaffe mdawaffe commented Aug 23, 2019 •
edited
Loading

Changes proposed in this Pull Request:

It's much easier to see what's going on if you look at this commit by commit.

  • HTTPS links in comments.
  • Clickable HTTPS links that do not require string changes.
  • Clickable HTTPS links that do require string changes.
  • HTTPS for shortcodes and embeds.
  • Some functional changes.

Only the last two need real testing.

That there are a large number of HTTP/legacy resources referenced in Jetpack was pointed out to us by @forced-request. Thanks for helping us clean this up!

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No: bug fixes.

Testing instructions:

  • Does Jetpack Comments still work? Submit a new comment.
  • Does the notifications UI still work?
  • Most everything else is trivial.

Proposed changelog entry for your changes:

  • Use HTTPS URLs when linking to external sites when possible.

@mdawaffe mdawaffe added [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Notifications [Feature] Comments [Feature] Gravatar Hovercards [Feature] Shortcodes / Embeds [Feature] Custom CSS [Feature] Mobile Theme aka minileven [Feature] Extra Sidebar Widgets [Feature] VideoPress A feature to help you upload and insert videos on your site. Enhanced Distribution [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Sitemaps labels Aug 23, 2019
@mdawaffe mdawaffe requested a review from a team August 23, 2019 07:08
@mdawaffe mdawaffe self-assigned this Aug 23, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello mdawaffe! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31889-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Aug 23, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against cbc1a90

jeherve
jeherve previously approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 23, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 23, 2019
simison
simison reviewed Aug 23, 2019
View reviewed changes
modules/theme-tools/site-logo.php
@@ -1,7 +1,7 @@
<?php
/*
* Site Logo.
* @see http://jetpack.com/support/site-logo/
* @see https://jetpack.com/support/site-logo/
Copy link
Member

@simison simison Aug 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to just redirect to https://jetpack.com/features/design/

That might be fine 🤷‍♂

jeherve
jeherve previously approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again now that the tests pass.

@matticbot
Copy link
Contributor

mdawaffe, Your synced wpcom patch D31889-code has been updated.

@mdawaffe
Copy link
Member Author

Let's get this in before there are more conflicts :)

@mdawaffe mdawaffe merged commit fcd387a into master Aug 23, 2019
@mdawaffe mdawaffe deleted the update/http-to-https branch August 23, 2019 18:20
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 23, 2019
jeherve added a commit that referenced this pull request Aug 26, 2019
@jeherve
Changelog: add #13306
57adc17
jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@lezama lezama lezama approved these changes

@jeherve jeherve jeherve left review comments

Assignees

@mdawaffe mdawaffe

Labels
[Feature] Comments [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Feature] Custom CSS [Feature] Extra Sidebar Widgets [Feature] Gravatar Hovercards [Feature] Mobile Theme aka minileven [Feature] Notifications [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Shortcodes / Embeds [Feature] Sitemaps [Feature] VideoPress A feature to help you upload and insert videos on your site. Touches WP.com Files
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.
6 participants
@mdawaffe @matticbot @jetpackbot @simison @lezama @jeherve