-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Graph meta tags for archive pages. #13137
Add Open Graph meta tags for archive pages. #13137
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: August 6, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I left a few first comments.
I would also recommend running yarn build
in your local testing environment. It will bring you some additional tools to help you with developing, such as PHPCS.
You can get started with this here:
https://github.com/Automattic/jetpack/blob/master/docs/development-environment.md#before-moving-forward
Thanks for all your feedback, @jeherve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my tests. 👍
Caution: This PR has changes that must be merged to WordPress.com |
* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335
Previously, Open Graph tags were added only for pages that were singular, home, or author archives. These changes add Open Graph meta tags to all archive pages.
Fixes #1987
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
This updates the existing Open Graph meta tag functionality to apply appropriate tags to archive pages.
Testing instructions:
To test Category pages:
To test Tag pages:
To test custom post type archives:
To test custom taxonomy archive pages:
To test date archive pages:
Proposed changelog entry for your changes: