Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: load rtl stylesheet for dashboard widget. #13268

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Stats: load rtl stylesheet for dashboard widget. #13268

merged 1 commit into from
Aug 21, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 20, 2019

Fixes #13207

Changes proposed in this Pull Request:

  • On RTL sites, load the correct stylesheet in the main dashboard.

Testing instructions:

  • Start from a Jetpack site with an RTL language set, such as Hebrew.
  • Activate Stats.
  • Visit the main dashboard at /wp-admin
  • Notice the broken widget title

image

  • Apply this patch
  • Notice the widget now looks better:

image

Proposed changelog entry for your changes:

  • Stats: load RTL stylesheet for dashboard widget, to fix layout issues on RTL language sites.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages labels Aug 20, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 20, 2019
@jeherve jeherve requested a review from a team August 20, 2019 08:44
@jeherve jeherve self-assigned this Aug 20, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against 28b290a

kbrown9
kbrown9 approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@kbrown9 kbrown9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this using the provided testing instructions, and everything looks great! The widget title was displayed properly with an RTL language.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 21, 2019
@dereksmart dereksmart merged commit b21c0ca into master Aug 21, 2019
@dereksmart dereksmart deleted the fix/i18n-stats-dash-widget branch August 21, 2019 12:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 21, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
@jeherve
Changelog: add #13268
8d36567
jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrown9 kbrown9 kbrown9 approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.

Stats Header in Jetpack Dashboard Overlaps When Language Set to Hebrew
5 participants
@jeherve @jetpackbot @kbrown9 @dereksmart @matticbot