Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update illustration colors to use Color Studio v2 #13127

Merged
merged 6 commits into from
Aug 14, 2019
Merged

Update illustration colors to use Color Studio v2 #13127

merged 6 commits into from
Aug 14, 2019

Conversation

crunnells
Copy link
Contributor

@crunnells crunnells commented Jul 24, 2019 •
edited
Loading

Part of our Hack week project to update the illustrations to use the new Color Studio v2 that dropped last week.

Changes proposed in this Pull Request:

  • Updates existing illustrations with new colors.

Old Illustrations (Free Plan)
L8xVpZA8Rg-3000x3000

New Illustrations (Free Plan)
Screenshot_2019-07-29 Jetpack ‹ Hollow Macaroni — WordPress

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Not a new feature, just updating assets. More info here: p6TEKc-2SC-p2

Testing instructions:

  • Activate and Connect Jetpack
  • Go to My Plan
  • Note that the illustrations have changed from drab to fab (tm)

Proposed changelog entry for your changes:

  • Update illustration colors

@crunnells crunnells added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu DO NOT MERGE don't merge it! labels Jul 24, 2019
@crunnells crunnells requested a review from a team July 24, 2019 23:39
@jetpackbot
Copy link

jetpackbot commented Jul 24, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against 4a44fe8

@olesyabrk
Copy link

so awesome to see it come together! --away with the grays --drab to fab ✨

@crunnells
Update & optimize SVGs
c1c910b 
Went back to the original SVG files and replaced classnames and colors to match the new files. Also optimized in a few spots (removed nested groups, invisible elements, etc).
@crunnells
Update jetpack-gutenberg.svg
098fd8a 
Missed this one earlier.
@crunnells crunnells added [Status] Design Review Complete [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed DO NOT MERGE don't merge it! [Status] Needs Design Review Design has been added. Needs a review! [Status] In Progress labels Jul 29, 2019
@crunnells
Copy link
Contributor Author

@jeherve Any chance we can squeeze this one into the next release?

@crunnells
Update stats-people.svg
af5a547 
Missed this one in the earlier audit.
@jeherve
Copy link
Member

jeherve commented Jul 30, 2019

@crunnells Sorry, I missed your comment, and I just shipped the Beta. It's going to have to be in the next release now, if that's okay with you.

@jeherve jeherve added this to the 7.7 milestone Jul 30, 2019
jeherve
jeherve previously approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It looks better than before! I think this should be good to merge.

Worth noting that this also impacts other screens that rely on the SVG, like the main connection screen.

Also worth noting that we do have a few layout issues in IE11 right now, but they were not introduced with this PR:

screenshot 2019-07-31 at 18 26 39

screenshot 2019-07-31 at 18 25 09

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 31, 2019
@jeherve
Copy link
Member

jeherve commented Jul 31, 2019

I logged the IE11 layout issues in #13161

@crunnells
Copy link
Contributor Author

@jeherve Thanks for the review and IE11 reports! I'll look into those.

@crunnells
Update jetpack-gutenberg.svg
09a2794 
SVG optimization (created outlines from all strokes, ran thru SVGO)
@crunnells
Update stats-people.svg
4a44fe8 
The graph shapes got changed from the original illustrations; this update fixes them.
mdawaffe
mdawaffe approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@mdawaffe mdawaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom - purty!

@mdawaffe mdawaffe merged commit 48d657e into master Aug 14, 2019
@mdawaffe mdawaffe deleted the update/illustrations-colorstudio-v2 branch August 14, 2019 00:52
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 14, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
@jeherve
Changelog: add #13127
432721c
jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
@jeherve jeherve mentioned this pull request Sep 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdawaffe mdawaffe mdawaffe approved these changes

@jeherve jeherve jeherve left review comments

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

@jeffgolenski jeffgolenski Awaiting requested review from jeffgolenski

Assignees

@crunnells crunnells

@olesyabrk olesyabrk

Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Design Review Complete [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.
6 participants
@crunnells @jetpackbot @olesyabrk @jeherve @mdawaffe @matticbot