Enhancement: Cleaning up and restyling jetpack related banner notices within wp-admin #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection Banner: cleaning up scss and verbiage changes for the connection banner displayed within /wp-admin/plugins/
jeffgolenski
changed the title
Management Banner: cleaning up styles and verbiage of the centralized management banner that’s displayed in /wp-admin/ if the manage feature is inactive.
ID Crisis Banner: Removing styling since it won't be used anymore. cc @dereksmart
Jetpack Banners: cleaning un-needed scss and adopting more core styles. Included removing some html elements and adding certain classes to elements.
Connect Banner: testing different images & building out structure
Banner Notices: cleaning up code and removing images - they don’t work well in the banners, as is.
| <div id="message" class="updated jetpack-message jp-banner" style="display:block !important;"> | ||
| <a class="jp-banner__dismiss" href="<?php echo esc_url( $dismiss_and_deactivate_url ); ?>" title="<?php esc_attr_e( 'Dismiss this notice and deactivate Jetpack.', 'jetpack' ); ?>"></a> | ||
| <div id="message" class="updated jp-banner"> | ||
| <a href="<?php echo esc_url( $dismiss_and_deactivate_url ); ?>" class="notice-dismiss" title="Dismiss this notice."></a> |
- making sure titles of dismiss buttons are translatable - ensuring out-going links are https - writing proper php for to link to jetpack dashboard from within the connection banner (learn more)
|
Looks so much better! LGTM |
jeherve
pushed a commit
that referenced
this pull request
Aug 20, 2019
The warning about Jetpack Protect's network activation warning is not dismissible. It is also not pretty :) Both have been problems since #3841. * Use markup compatible with Core's notices. * Hook some JS into Core's notice dismissal to handle changing saved state.
jeherve
added a commit
that referenced
this pull request
Aug 23, 2019
* Protect: Dismissible Network Activation Warning The warning about Jetpack Protect's network activation warning is not dismissible. It is also not pretty :) Both have been problems since #3841. * Use markup compatible with Core's notices. * Hook some JS into Core's notice dismissal to handle changing saved state. * Escape translations. Co-Authored-By: Miguel Lezama <[email protected]> Co-authored-by: Jeremy Herve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Cleaning up and restyling jetpack related banner notifications within wp-admin (but outside new jetpack dashboard) - match the core notification styles. Not altering current logic, just cleaning them up, visually. Will revisit these soon.
Connection Banner Before:
Connection Banner After:
Adopts wp-admin core styles with some very slight, lightweight adjustments...
Manage Banner After
