Introduce BaseConnectorTest, merging AbstractTestDistributedQueries and AbstractTestIntegrationSmokeTest #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparatory step to run full `BaseConnectorTest` in this configuration as well.
This is so that connectors do not need to test both with caching enabled and disabled. It is a preparatory step to merge `AbstractTestDistributedQueries`- and `AbstractTestIntegrationSmokeTest`-based test class hierarchies into one.
The test is added back as it was, with only the class being deprecated and javadoc changed accordingly.
Extend `BaseConnectorTest` from `AbstractTestDistributedQueries` (removing duplicated test methods) and run it against base-jdbc with H2.
findepi
force-pushed
the
findepi/base-connector-test
branch
2 times, most recently
from
900eca5 to
7cef5ca
Compare
…SmokeTest Merge `TestPostgreSqlDistributedQueries` into `TestPostgreSqlIntegrationSmokeTest` utilizing `BaseConnectorTest` base class.
Merge `TestRedisDistributed` into `TestRedisIntegrationSmokeTest` utilizing `BaseConnectorTest` base class.
findepi
force-pushed
the
findepi/base-connector-test
branch
from
7cef5ca to
0feb871
Compare
This was referenced Feb 23, 2021
|
I used to have a test that was verifying that all tests from deprecated smoke tests class are added to |
Good point and I am aware. |
kokosing
approved these changes
Feb 23, 2021
Ok. |
losipiuk
reviewed
Feb 23, 2021
| @@ -20,9 +20,11 @@ | |||
| import io.trino.sql.planner.plan.FilterNode; | |||
| import io.trino.sql.planner.plan.MarkDistinctNode; | |||
| import io.trino.sql.planner.plan.ProjectNode; | |||
| import io.trino.testing.AbstractTestIntegrationSmokeTest; | |||
| import io.trino.testing.BaseConnectorTest; | |||
There was a problem hiding this comment.
nit: commit summary to long in Merge TestPostgreSql...
losipiuk
approved these changes
Feb 23, 2021
This was referenced Mar 2, 2021
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of the idea presented in #5871.
Idea is @kokosing 's and all bugs are mine own.
For #6997