Rework Oracle tests to use BaseConnectorTest #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Mar 2, 2021
| @@ -42,18 +46,18 @@ protected QueryRunner createQueryRunner() | |||
| .put("connection-user", TEST_USER) | |||
| .put("connection-password", TEST_PASS) | |||
| .put("allow-drop-table", "true") | |||
| .put("oracle.connection-pool.enabled", "false") | |||
| .put("oracle.connection-pool.enabled", "true") | |||
There was a problem hiding this comment.
Git's rename detection is awesome :)
losipiuk
reviewed
Mar 2, 2021
|
|
||
| public class TestOraclePoolIntegrationSmokeTest | ||
| extends BaseOracleIntegrationSmokeTest | ||
| public class TestRemarksReportingOraclePoolConnectorTest |
There was a problem hiding this comment.
Possibly we want to have a real "smoke" base class for this one.
Maybe add //TODO with an issue. Not sure how we want to proceed with that. So we don't get where we started. And have two arbitrary split test classes. cc: @findepi
losipiuk
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Oracle tests to use the single connector base test class added in #6989