Add dedicated test for queries with caching #6986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Feb 22, 2021
|
|
||
| import static io.trino.plugin.jdbc.H2QueryRunner.createH2QueryRunner; | ||
|
|
||
| public class TestJdbcCachingQueries |
There was a problem hiding this comment.
TestJdbcDistributedQueriesWithMetadataCaching?
I understand that other tests like io.trino.plugin.postgresql.TestPostgreSqlDistributedQueries can use caching if they like. It is irrelevant for for them, right?
There was a problem hiding this comment.
We should test connectors with default settings as much as possible, but other than that -- yes
TestJdbcDistributedQueriesWithMetadataCaching
i don't want to encode the promise that all "AbstractTestDistributedQueries" are gonna always be included here
kokosing
approved these changes
Feb 22, 2021
findepi
force-pushed
the
findepi/add-dedicated-test-for-queries-with-caching-7f9277
branch
from
b9662ec to
240f068
Compare
kokosing
approved these changes
Feb 22, 2021
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcCachingQueries.java
Show resolved
Hide resolved
| import static io.trino.plugin.jdbc.H2QueryRunner.createH2QueryRunner; | ||
|
|
||
| public class TestJdbcCachingQueries | ||
| // TODO define shorter tests set that exercises various read and write scenarios (a.k.a. "a smoke test") |
There was a problem hiding this comment.
sure, but this feels more like your idea, so feel free to create one :)
findepi
force-pushed
the
findepi/add-dedicated-test-for-queries-with-caching-7f9277
branch
from
240f068 to
67b1de2
Compare
This is a preparatory step to run full `BaseConnectorTest` in this configuration as well.
This is so that connectors do not need to test both with caching enabled and disabled. It is a preparatory step to merge `AbstractTestDistributedQueries`- and `AbstractTestIntegrationSmokeTest`-based test class hierarchies into one.
findepi
force-pushed
the
findepi/add-dedicated-test-for-queries-with-caching-7f9277
branch
from
67b1de2 to
1da48e1
Compare
9 tasks
|
Merged in #6989 |
findepi
deleted the
findepi/add-dedicated-test-for-queries-with-caching-7f9277
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that connectors do not need to test both with
caching enabled and disabled. It is a preparatory step to merge
AbstractTestDistributedQueries- andAbstractTestIntegrationSmokeTest-based test class hierarchies intoone.
Relates to #5871 and is meant to supersede part of that PR.
For #6997