Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dedicate test suite for connector testing #6997

Open
5 of 9 tasks
kokosing opened this issue Feb 23, 2021 · 1 comment
Open
5 of 9 tasks

Provide dedicate test suite for connector testing #6997

kokosing opened this issue Feb 23, 2021 · 1 comment
Labels
enhancement New feature or request test

Comments

@kokosing
Copy link
Member

kokosing commented Feb 23, 2021

Currently we have are using two tests suites: AbtractTestDistributedQueries and AbstractTestIntegrationSmokeTest. Where each connector implements them both of and also add more connector specifics tests to either one of these or to separate. This has following issues:

  • If one adds a test is not clear where to put the test.
  • It is difficult to add a new generic tests dedicated only for connectors.

Solution for this is to merge two test classes above into one and create one common base test class for connector testing.

CC: @trinodb/maintainers

@kokosing
Copy link
Member Author

One issue of this idea is the need of the migration of all connector tests to this new framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Development

No branches or pull requests

2 participants