Merge DistributedQueries and Smoke test class in MySQL connector #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
changed the title
kokosing
reviewed
Feb 24, 2021
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
...trino-mysql/src/test/java/io/trino/plugin/mysql/TestGlobalTransactionMySqlConnectorTest.java
Show resolved
Hide resolved
findepi
approved these changes
Feb 24, 2021
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
...trino-mysql/src/test/java/io/trino/plugin/mysql/TestGlobalTransactionMySqlConnectorTest.java
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/mysql-base-test
branch
from
57e6bb9 to
0d8d92a
Compare
|
ac |
|
Needed to fix |
findepi
reviewed
Feb 24, 2021
| MaterializedResult result = computeActual("SHOW TABLES"); | ||
| assertThat(result.getOnlyColumnAsSet()).containsAll(expectedTables); | ||
| assertThat(result.getOnlyColumnAsSet()).containsAll(createdTpchTables()); |
There was a problem hiding this comment.
Don't expose this. Simpliy enumerat those tables, which are required by other test methods. this is sufficient from this test perspective
| { | ||
| protected static final List<TpchTable<?>> TPCH_TABLES = ImmutableList.of(CUSTOMER, NATION, ORDERS, REGION, LINE_ITEM); |
There was a problem hiding this comment.
This can be defined on BaseConnectorTest level and named like REQUIRED_TPCH_TABLES
There was a problem hiding this comment.
I defined it in AbstractTestQueries.java . Can be moved to BaseConnectorTest when we will be removing ATQ
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/mysql-base-test
branch
2 times, most recently
from
6189a98 to
601e35c
Compare
|
@findepi PTAL |
findepi
reviewed
Feb 24, 2021
plugin/trino-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/RaptorQueryRunner.java
Outdated
Show resolved
Hide resolved
Comment on lines
66
to
68
| if (createTpchTables) { | ||
| tables = TpchTable.getTables(); | ||
| } |
There was a problem hiding this comment.
same here -- one should pass in empty list of tables instead.
There was a problem hiding this comment.
if many places to update -- just add a TODO note in the code
| @@ -49,6 +50,12 @@ private PhoenixQueryRunner() | |||
|
|
|||
| public static DistributedQueryRunner createPhoenixQueryRunner(TestingPhoenixServer server, Map<String, String> extraProperties) | |||
| throws Exception | |||
| { | |||
There was a problem hiding this comment.
can we remove this overload? how many places?
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/mysql-base-test
branch
2 times, most recently
from
e92d2d9 to
573e9ab
Compare
findepi
approved these changes
Feb 24, 2021
| public static DistributedQueryRunner createRaptorQueryRunner( | ||
| Map<String, String> extraProperties, | ||
| boolean loadTpch, |
| } | ||
|
|
||
| public static DistributedQueryRunner createIcebergQueryRunner(Map<String, String> extraProperties, FileFormat format, boolean createTpchTables) |
losipiuk
force-pushed
the
lo/mysql-base-test
branch
from
573e9ab to
4caa1cb
Compare
kokosing
reviewed
Feb 24, 2021
| // TODO extend BaseConnectorTest | ||
| extends AbstractTestIntegrationSmokeTest | ||
| abstract class BaseMySqlConnectorTest | ||
| // TODO(https://github.com/trinodb/trino/issues/7019) define shorter tests set that exercises various read and write scenarios (a.k.a. "a smoke test") |
There was a problem hiding this comment.
TODO is in the wrong place. You need one full test suite and one smoke test for TestGlobalTransactionMySqlConnectorTest.
There was a problem hiding this comment.
Oh - I guess I read the intention wrongly, and assumed we want both smoke and full tests, so we can run this or this depending on the situation.
TestMySqlDistributedQueries is merged in into BaseMySqlIntegrationSmokeTest which is renamed to BaseMySqlConnectorTest. The subclasses are renamed to match new naming pattern.
losipiuk
force-pushed
the
lo/mysql-base-test
branch
from
4caa1cb to
c81138f
Compare
This was referenced Feb 25, 2021
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestMySqlDistributedQueries is merged in into
BaseMySqlIntegrationSmokeTest which is renamed to BaseMySqlConnectorTest.
The subclasses are renamed to match new naming pattern.