Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Hive tests to use BaseConnectorTest #7113

Closed
losipiuk opened this issue Mar 2, 2021 · 6 comments · Fixed by #7993
Closed

Migrate Hive tests to use BaseConnectorTest #7113

losipiuk opened this issue Mar 2, 2021 · 6 comments · Fixed by #7993
Assignees
@xuboqing
Labels
good first issue Good for newcomers test

Comments

@losipiuk
Copy link
Member

losipiuk commented Mar 2, 2021

#6989 introduced new BaseConnectorTest test class which replaces AbstractTestDistributedQueries and AbstractTestIntegrationSmokeTest.

Scope of this ticket is to restructure Hive test code to follow new pattern.
TestHiveIntegrationSmokeTest should be merged with TestHiveDistributedQueries to form TestHiveConnectorTest

Please ensure that TestHiveConnectorTest is created as a rename of TestHiveIntegrationSmokeTest so we keep as much Git history as possible.

A PR which restructures MySQL tests is a good reference: #7011
@losipiuk losipiuk added good first issue Good for newcomers test labels Mar 2, 2021
@MariyaR
Copy link
Contributor

MariyaR commented Mar 12, 2021

Hi,
may I try to work on this?

@findepi
Copy link
Member

findepi commented Mar 12, 2021

sure, go for it!

@xuboqing
Copy link

I wanna have a try and maybe finish it in two days, could you please assign this to me?

@losipiuk
Copy link
Member Author

@MariyaR are you still working on this one?

@MariyaR
Copy link
Contributor

MariyaR commented Apr 22, 2021

@losipiuk no, I am sorry, I am very limited in time these days

@losipiuk
Copy link
Member Author

@losipiuk no, I am sorry, I am very limited in time these days

No worries :) @xuboqing feel free to give it a try :)

@losipiuk losipiuk assigned xuboqing and unassigned MariyaR Apr 22, 2021
@xuboqing xuboqing mentioned this issue Apr 23, 2021
Closed
@wendigo wendigo mentioned this issue May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuboqing xuboqing

Labels
good first issue Good for newcomers test
Milestone
No milestone
4 participants
@findepi @losipiuk @MariyaR @xuboqing