Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate HiveIntegrationSmokeTest to ConnectorTest #7993

Merged
merged 2 commits into from
May 21, 2021
Merged

Migrate HiveIntegrationSmokeTest to ConnectorTest #7993

merged 2 commits into from
May 21, 2021

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 20, 2021 •
edited
Loading

Fixes #7113

@cla-bot cla-bot bot added the cla-signed label May 20, 2021
@wendigo wendigo requested review from findepi and hashhar May 20, 2021 09:20
hashhar
hashhar previously approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run CI with tests:hive label?

LGTM % comments and CI.

plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java Outdated Show resolved Hide resolved
@wendigo wendigo force-pushed the serafin/hive-connector-test branch from f6ef1bd to f634b91 Compare May 20, 2021 10:50
@wendigo
Copy link
Contributor Author

wendigo commented May 20, 2021

PTAL @hashhar

@wendigo wendigo force-pushed the serafin/hive-connector-test branch from f634b91 to f771de2 Compare May 20, 2021 11:05
@hashhar hashhar self-requested a review May 20, 2021 11:42
@hashhar hashhar dismissed their stale review May 20, 2021 11:42

stale

@hashhar hashhar merged commit 7975de7 into trinodb:master May 21, 2021
@ebyhr ebyhr mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Hive tests to use BaseConnectorTest
2 participants
@wendigo @hashhar