Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cassandra tests to use BaseConnectorTest #7111

Closed
losipiuk opened this issue Mar 2, 2021 · 5 comments · Fixed by #7626
Closed

Migrate Cassandra tests to use BaseConnectorTest #7111

losipiuk opened this issue Mar 2, 2021 · 5 comments · Fixed by #7626
Assignees
@findinpath
Labels
good first issue Good for newcomers test

Comments

@losipiuk
Copy link
Member

losipiuk commented Mar 2, 2021 •
edited
Loading

#6989 introduced new BaseConnectorTest test class which replaces AbstractTestDistributedQueries and AbstractTestIntegrationSmokeTest.

Scope of this ticket is to restructure Cassandra test code to follow new pattern.
TestCassandraIntegrationSmokeTest should be merged with BaseCassandraDistributedQueries to form BaseTestCassandraConnectorTest
Then on top of that we should create TestCassandraConnectorTest and TestCassandraLatestConnectorTest (removing TestCassandraDistributedQueries and TestCassandraDistributedQueriesLatest)

Please ensure that BaseTestCassandraConnectorTest is created as a rename of TestCassandraIntegrationSmokeTest so we keep as much Git history as possible.

A PR which restructures MySQL tests is a good reference: #7011
@losipiuk losipiuk added good first issue Good for newcomers test labels Mar 2, 2021
@manan9299
Copy link
Member

@losipiuk Can I work on this issue? I am new here and would love to give this a try. Could you please assign this issue to me?

@findepi
Copy link
Member

findepi commented Mar 6, 2021

@manan9299 sure, go for it!

@findinpath
Copy link
Contributor

I have already experience with refactoring to BaseConnectorTest and I'm also familiar with Cassandra. I think I could provide in a day or two a working PR for this issue. Can I be assigned on this one?

@findepi
Copy link
Member

findepi commented Apr 17, 2021

@findinpath let's ask @manan9299 whether they are actually working on this

@manan9299 ?

@manan9299
Copy link
Member

@findinpath sure, go ahead. I got caught up in something else and couldn't find the time to work on this issue.

@manan9299 manan9299 removed their assignment Apr 17, 2021
@findinpath findinpath mentioned this issue Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findinpath findinpath

Labels
good first issue Good for newcomers test
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate Cassandra tests to use BaseConnectorTest findinpath/trino
4 participants
@findepi @losipiuk @manan9299 @findinpath