Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cassandra tests to use BaseConnectorTest #7626

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Migrate Cassandra tests to use BaseConnectorTest #7626

merged 2 commits into from
Apr 25, 2021

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Apr 17, 2021 •
edited by ebyhr
Loading

This PR adresses #7111

Migrate Cassandra tests to use BaseConnectorTest:

  • TestCassandraIntegrationSmokeTest.java has been renamed to BaseCassandraConnectorTest.java . The tests from BaseCassandraDistributedQueries.java have been merged also to BaseCassandraConnectorTest.java.
  • TestCassandraDistributedQueries.java has been renamed to TestCassandraConnectorTest.java
  • TestCassandraLatestConnectorSmokeTest.java has been renamed to TestCassandraConnectorTest.java

Fixes #7111

@cla-bot
Copy link

cla-bot bot commented Apr 17, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@findinpath findinpath changed the title Migrate Cassandra tests to use BaseConnectorTest: Migrate Cassandra tests to use BaseConnectorTest Apr 17, 2021
@cla-bot
Copy link

cla-bot bot commented Apr 17, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 17, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 17, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 18, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2021
hashhar
hashhar reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending in the PR. ❤️

Some comments.

plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/BaseCassandraConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/BaseCassandraConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/BaseCassandraConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/BaseCassandraConnectorTest.java Outdated Show resolved Hide resolved
...rino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraLatestConnectorTest.java Outdated Show resolved Hide resolved
...rino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraLatestConnectorTest.java Outdated Show resolved Hide resolved
@findinpath findinpath force-pushed the refactoring/7111 branch 2 times, most recently from f8a832c to b8d021e Compare April 20, 2021 21:41
hashhar
hashhar approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

Thanks a lot, looks good to be merged with SkipExceptions in place.

plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraConnectorTest.java Show resolved Hide resolved
...cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraLatestConnectorSmokeTest.java Outdated Show resolved Hide resolved
@hashhar hashhar requested a review from ebyhr April 21, 2021 05:41
@findinpath findinpath force-pushed the refactoring/7111 branch 3 times, most recently from 89c7098 to 402ccf6 Compare April 22, 2021 20:48
ebyhr
ebyhr approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Could you fix the 1st commit's body since it's too long (205) as a line? e.g.,

Rename TestCassandraIntegrationSmokeTest to TestCassandraConnectorTest.
BaseCassandraDistributedQueries is merged into TestCassandraConnectorTest.

plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraConnectorTest.java Outdated Show resolved Hide resolved
...cassandra/src/test/java/io/trino/plugin/cassandra/TestCassandraLatestConnectorSmokeTest.java Outdated Show resolved Hide resolved
@findinpath
Migrate Cassandra tests to use BaseConnectorTest
d0a84c8 
Rename TestCassandraIntegrationSmokeTest.java to TestCassandraConnectorTest.java .
Merge BaseCassandraDistributedQueries.java tests to TestCassandraConnectorTest.java.
@findinpath
Test against Cassandra 3.11.10
36fd449
@hashhar hashhar merged commit 205e79d into trinodb:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Cassandra tests to use BaseConnectorTest
3 participants
@findinpath @ebyhr @hashhar