Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smoke test for TestGlobalTransactionMySqlConnectorTest #7019

Closed
losipiuk opened this issue Feb 24, 2021 · 3 comments
Closed

Use smoke test for TestGlobalTransactionMySqlConnectorTest #7019

losipiuk opened this issue Feb 24, 2021 · 3 comments
Milestone
353

Comments

@losipiuk
Copy link
Member

losipiuk commented Feb 24, 2021 •
edited
Loading

No description provided.

@losipiuk losipiuk mentioned this issue Feb 24, 2021
Merged
@losipiuk losipiuk changed the title Define smoke test classes for connectors Use smoke test for TestGlobalTransactionMySqlConnectorTest Feb 25, 2021
@findepi
Copy link
Member

findepi commented Mar 1, 2021

The original title was: "Define smoke test classes for connectors" and it's worth keeping.
I wouldn't want to manage this just for MySQL connector.

Perhaps, we could make BaseConnectorTest work in a smoke fashion, where it skips certain methods, or finishes certain tests early when in "smoke mode".

cc @kokosing

@losipiuk
Copy link
Member Author

losipiuk commented Mar 1, 2021

The original title was: "Define smoke test classes for connectors" and it's worth keeping.
I wouldn't want to manage this just for MySQL connector.

Yeah possibly. But having more granular issues allows for having more targetted TODO(issue) comments. Do we want to have both?

@findepi
Copy link
Member

findepi commented Mar 17, 2021

Done in #7155

@findepi findepi closed this as completed Mar 17, 2021
@findepi findepi added this to the 353 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
353
Development

No branches or pull requests
2 participants
@findepi @losipiuk